Bug 1846191 assert that a cubeb_mock_stream is not used after it is d…

…estroyed r=padenot,pehrsons

while it may still be alive as a MockCubebStream.

Differential Revision: https://phabricator.services.mozilla.com/D185026

dom/media/gtest/MockCubeb.cpp

@@ -244,7 +244,8 @@ void MockCubebStream::Destroy() {
   // This provides an extra STOPPED state callback as with audioipc.
   // It also ensures that this stream is removed from MockCubeb::mLiveStreams.
   Stop();
-  MockCubeb::AsMock(context)->StreamDestroy(AsCubebStream());
+  mDestroyed = true;
+  MockCubeb::AsMock(context)->StreamDestroy(this);
 }
 
 int MockCubebStream::RegisterDeviceChangedCallback(
@@ -257,11 +258,14 @@ int MockCubebStream::RegisterDeviceChangedCallback(
 }
 
 cubeb_stream* MockCubebStream::AsCubebStream() {
+  MOZ_ASSERT(!mDestroyed);
   return reinterpret_cast<cubeb_stream*>(this);
 }
 
 MockCubebStream* MockCubebStream::AsMock(cubeb_stream* aStream) {
-  return reinterpret_cast<MockCubebStream*>(aStream);
+  auto* mockStream = reinterpret_cast<MockCubebStream*>(aStream);
+  MOZ_ASSERT(!mockStream->mDestroyed);
+  return mockStream;
 }
 
 cubeb_devid MockCubebStream::GetInputDeviceID() const { return mInputDeviceID; }
@@ -591,9 +595,8 @@ int MockCubeb::StreamInit(cubeb* aContext, cubeb_stream** aStream,
   return CUBEB_OK;
 }
 
-void MockCubeb::StreamDestroy(cubeb_stream* aStream) {
-  RefPtr<SmartMockCubebStream> mockStream =
-      dont_AddRef(MockCubebStream::AsMock(aStream)->mSelf);
+void MockCubeb::StreamDestroy(MockCubebStream* aStream) {
+  RefPtr<SmartMockCubebStream> mockStream = dont_AddRef(aStream->mSelf);
   mStreamDestroyEvent.Notify(mockStream);
 }
 

dom/media/gtest/MockCubeb.h

@@ -248,6 +248,7 @@ class MockCubebStream {
   std::atomic_bool mFastMode{false};
   std::atomic_bool mForceErrorState{false};
   std::atomic_bool mForceDeviceChanged{false};
+  std::atomic_bool mDestroyed{false};
   std::atomic<uint64_t> mPosition{0};
   AudioGenerator<AudioDataValue> mAudioGenerator;
   AudioVerifier<AudioDataValue> mAudioVerifier;
@@ -367,7 +368,7 @@ class MockCubeb {
                  cubeb_data_callback aDataCallback,
                  cubeb_state_callback aStateCallback, void* aUserPtr);
 
-  void StreamDestroy(cubeb_stream* aStream);
+  void StreamDestroy(MockCubebStream* aStream);
 
   void GoFaster();
   void DontGoFaster();