Skip to content

Commit

Permalink
Bug 1339673 - Add an option to disable building the gtest xul and set…
Browse files Browse the repository at this point in the history
… it for valgrind builds in automation. r=ted

MozReview-Commit-ID: 1doicRjGhfY

--HG--
extra : rebase_source : 9f9cbf5c7a9f4e29e806a02c27106fbc1519fc86
  • Loading branch information
chmanchester committed Feb 16, 2017
1 parent fcd910e commit e2e1a84
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions browser/config/mozconfigs/linux32/valgrind
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
ac_add_options --enable-valgrind
ac_add_options --disable-jemalloc
ac_add_options --disable-install-strip
ac_add_options --disable-gtest-in-build

# Include the override mozconfig again (even though the above includes it)
# since it's supposed to override everything.
Expand Down
1 change: 1 addition & 0 deletions browser/config/mozconfigs/linux64/valgrind
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
ac_add_options --enable-valgrind
ac_add_options --disable-jemalloc
ac_add_options --disable-install-strip
ac_add_options --disable-gtest-in-build

# Include the override mozconfig again (even though the above includes it)
# since it's supposed to override everything.
Expand Down
10 changes: 8 additions & 2 deletions moz.configure
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,18 @@ def build_backends(backends):

set_config('BUILD_BACKENDS', build_backends)

option('--disable-gtest-in-build',
help='Force disable building the gtest libxul during the build.',
when='--enable-compile-environment')

# Determine whether to build the gtest xul. This happens in automation
# on Desktop platforms with the exception of Windows PGO, where linking
# xul-gtest.dll takes too long.
@depends('MOZ_PGO', build_project, target, 'MOZ_AUTOMATION',
@depends('MOZ_PGO', build_project, target, 'MOZ_AUTOMATION', '--disable-gtest-in-build',
when='--enable-compile-environment')
def build_gtest(pgo, build_project, target, automation):
def build_gtest(pgo, build_project, target, automation, enabled):
if not enabled:
return None
if (automation and build_project == 'browser' and
not (pgo and target.os == 'WINNT')):
return True
Expand Down

0 comments on commit e2e1a84

Please sign in to comment.