Skip to content

Commit

Permalink
Bug 1593545 - Disable DocumentChannel assertion in non-fission mode r…
Browse files Browse the repository at this point in the history
…=mattwoodrow

Differential Revision: https://phabricator.services.mozilla.com/D52804

--HG--
extra : moz-landing-system : lando
  • Loading branch information
PaulBone committed Nov 14, 2019
1 parent 0ec5e07 commit ebcead8
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions netwerk/protocol/http/nsHttpChannel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2593,6 +2593,15 @@ void nsHttpChannel::AssertNotDocumentChannel() {
return;
}

#ifndef DEBUG
if (!StaticPrefs::fission_autostart()) {
// This assertion is firing in the wild (Bug 1593545) and its not clear
// why. Disable the assertion in non-fission non-debug configurations to
// avoid crashing user's browsers until we're done dogfooding fission.
return;
}
#endif

nsCOMPtr<nsIParentChannel> parentChannel;
NS_QueryNotificationCallbacks(this, parentChannel);
RefPtr<DocumentChannelParent> documentChannelParent =
Expand Down

0 comments on commit ebcead8

Please sign in to comment.