Backed out 5 changesets (bug 1811278) for causing lint failures on br…

…owser_bug435325.js CLOSED TREE

Backed out changeset 715821104ffa (bug 1811278)
Backed out changeset 6f116715687d (bug 1811278)
Backed out changeset 16e69d940e3f (bug 1811278)
Backed out changeset 9dc0451ca213 (bug 1811278)
Backed out changeset 9f60a414e711 (bug 1811278)

.eslintrc.js

@@ -574,6 +574,189 @@ module.exports = {
         // That are all files that produes warnings in the existing test infrastructure.
         // Since our focus is that new tests won't use http without thinking twice we exempt
         // these test files for now. Bug 1758951
+        "browser/base/content/test/about/browser_aboutHome_search_POST.js",
+        "browser/base/content/test/about/browser_aboutNetError.js",
+        "browser/base/content/test/about/browser_aboutNetError_csp_iframe.js",
+        "browser/base/content/test/about/browser_aboutNetError_xfo_iframe.js",
+        "browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarEmpty.js",
+        "browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarPrefs.js",
+        "browser/base/content/test/about/browser_bug435325.js",
+        "browser/base/content/test/alerts/browser_notification_close.js",
+        "browser/base/content/test/alerts/browser_notification_do_not_disturb.js",
+        "browser/base/content/test/alerts/browser_notification_open_settings.js",
+        "browser/base/content/test/alerts/browser_notification_remove_permission.js",
+        "browser/base/content/test/alerts/browser_notification_replace.js",
+        "browser/base/content/test/alerts/browser_notification_tab_switching.js",
+        "browser/base/content/test/backforward/browser_history_menu.js",
+        "browser/base/content/test/caps/browser_principalSerialization_json.js",
+        "browser/base/content/test/captivePortal/browser_captivePortal_https_only.js",
+        "browser/base/content/test/chrome/test_aboutCrashed.xhtml",
+        "browser/base/content/test/chrome/test_aboutRestartRequired.xhtml",
+        "browser/base/content/test/contextMenu/browser_contextmenu.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_contenteditable.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_input.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_keyword.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_save_blocked.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_share_macosx.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_share_win.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_spellcheck.js",
+        "browser/base/content/test/contextMenu/browser_contextmenu_touch.js",
+        "browser/base/content/test/contextMenu/browser_utilityOverlay.js",
+        "browser/base/content/test/contextMenu/browser_utilityOverlayPrincipal.js",
+        "browser/base/content/test/favicons/browser_favicon_cache.js",
+        "browser/base/content/test/favicons/browser_favicon_credentials.js",
+        "browser/base/content/test/favicons/browser_favicon_load.js",
+        "browser/base/content/test/favicons/browser_invalid_href_fallback.js",
+        "browser/base/content/test/favicons/browser_rooticon.js",
+        "browser/base/content/test/favicons/browser_title_flicker.js",
+        "browser/base/content/test/favicons/cookie_favicon.sjs",
+        "browser/base/content/test/fullscreen/browser_fullscreen_api_fission.js",
+        "browser/base/content/test/fullscreen/browser_fullscreen_enterInUrlbar.js",
+        "browser/base/content/test/general/browser_alltabslistener.js",
+        "browser/base/content/test/general/browser_backButtonFitts.js",
+        "browser/base/content/test/general/browser_beforeunload_duplicate_dialogs.js",
+        "browser/base/content/test/general/browser_bug1299667.js",
+        "browser/base/content/test/general/browser_bug356571.js",
+        "browser/base/content/test/general/browser_bug575561.js",
+        "browser/base/content/test/general/browser_bug578534.js",
+        "browser/base/content/test/general/browser_bug579872.js",
+        "browser/base/content/test/general/browser_bug594131.js",
+        "browser/base/content/test/general/browser_bug624734.js",
+        "browser/base/content/test/general/browser_bug676619.js",
+        "browser/base/content/test/general/browser_bug724239.js",
+        "browser/base/content/test/general/browser_bug749738.js",
+        "browser/base/content/test/general/browser_contentAltClick.js",
+        "browser/base/content/test/general/browser_domFullscreen_fullscreenMode.js",
+        "browser/base/content/test/general/browser_modifiedclick_inherit_principal.js",
+        "browser/base/content/test/general/browser_new_http_window_opened_from_file_tab.js",
+        "browser/base/content/test/general/browser_newTabDrop.js",
+        "browser/base/content/test/general/browser_page_style_menu.js",
+        "browser/base/content/test/general/browser_page_style_menu_update.js",
+        "browser/base/content/test/general/browser_plainTextLinks.js",
+        "browser/base/content/test/general/browser_refreshBlocker.js",
+        "browser/base/content/test/general/browser_restore_isAppTab.js",
+        "browser/base/content/test/general/browser_star_hsts.js",
+        "browser/base/content/test/general/browser_tab_detach_restore.js",
+        "browser/base/content/test/general/browser_tab_drag_drop_perwindow.js",
+        "browser/base/content/test/general/browser_tab_dragdrop.js",
+        "browser/base/content/test/general/browser_unknownContentType_title.js",
+        "browser/base/content/test/general/browser_viewSourceInTabOnViewSource.js",
+        "browser/base/content/test/general/browser_windowactivation.js",
+        "browser/base/content/test/keyboard/browser_popup_keyNav.js",
+        "browser/base/content/test/keyboard/browser_toolbarKeyNav.js",
+        "browser/base/content/test/menubar/browser_file_close_tabs.js",
+        "browser/base/content/test/menubar/browser_file_share.js",
+        "browser/base/content/test/metaTags/browser_bad_meta_tags.js",
+        "browser/base/content/test/pageActions/browser_PageActions_bookmark.js",
+        "browser/base/content/test/pageActions/browser_PageActions_overflow.js",
+        "browser/base/content/test/pageActions/browser_PageActions_removeExtension.js",
+        "browser/base/content/test/pageStyle/browser_disable_author_style_oop.js",
+        "browser/base/content/test/pageinfo/browser_pageinfo_iframe_media.js",
+        "browser/base/content/test/pageinfo/browser_pageinfo_images.js",
+        "browser/base/content/test/pageinfo/browser_pageinfo_security.js",
+        "browser/base/content/test/performance/browser_preferences_usage.js",
+        "browser/base/content/test/performance/browser_startup_content.js",
+        "browser/base/content/test/performance/browser_startup_content_subframe.js",
+        "browser/base/content/test/performance/browser_window_resize.js",
+        "browser/base/content/test/performance/head.js",
+        "browser/base/content/test/popupNotifications/browser_popupNotification.js",
+        "browser/base/content/test/popupNotifications/browser_popupNotification_2.js",
+        "browser/base/content/test/popupNotifications/browser_popupNotification_3.js",
+        "browser/base/content/test/popupNotifications/browser_popupNotification_4.js",
+        "browser/base/content/test/popupNotifications/browser_popupNotification_5.js",
+        "browser/base/content/test/popupNotifications/browser_popupNotification_no_anchors.js",
+        "browser/base/content/test/popupNotifications/browser_reshow_in_background.js",
+        "browser/base/content/test/popupNotifications/head.js",
+        "browser/base/content/test/popups/browser_popup_blocker_frames.js",
+        "browser/base/content/test/popups/browser_popup_blocker_identity_block.js",
+        "browser/base/content/test/popups/browser_popup_blocker_iframes.js",
+        "browser/base/content/test/popups/browser_popup_frames.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_background_tabs.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_categories.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_cookies_subview.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_cryptominers.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_fingerprinters.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_icon_state.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_open_preferences.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_pbmode_exceptions.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_report_breakage.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_shield_visibility.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_socialtracking.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_state.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_state_reset.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_subview_shim.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_telemetry.js",
+        "browser/base/content/test/protectionsUI/browser_protectionsUI_trackers_subview.js",
+        "browser/base/content/test/protectionsUI/file_protectionsUI_fetch.html",
+        "browser/base/content/test/protectionsUI/trackingAPI.js",
+        "browser/base/content/test/referrer/browser_referrer_click_pinned_tab.js",
+        "browser/base/content/test/referrer/head.js",
+        "browser/base/content/test/siteIdentity/browser_about_blank_same_document_tabswitch.js",
+        "browser/base/content/test/siteIdentity/browser_check_identity_state.js",
+        "browser/base/content/test/siteIdentity/browser_check_identity_state_pdf.js",
+        "browser/base/content/test/siteIdentity/browser_getSecurityInfo.js",
+        "browser/base/content/test/siteIdentity/browser_identityIcon_img_url.js",
+        "browser/base/content/test/siteIdentity/browser_identityPopup_custom_roots.js",
+        "browser/base/content/test/siteIdentity/browser_identity_UI.js",
+        "browser/base/content/test/siteIdentity/browser_iframe_navigation.js",
+        "browser/base/content/test/siteIdentity/browser_mcb_redirect.js",
+        "browser/base/content/test/siteIdentity/browser_mixedContentFramesOnHttp.js",
+        "browser/base/content/test/siteIdentity/browser_mixedContentFromOnunload.js",
+        "browser/base/content/test/siteIdentity/browser_no_mcb_on_http_site.js",
+        "browser/base/content/test/siteIdentity/browser_secure_transport_insecure_scheme.js",
+        "browser/base/content/test/siteIdentity/iframe_navigation.html",
+        "browser/base/content/test/siteIdentity/test_mcb_redirect.sjs",
+        "browser/base/content/test/siteIdentity/test_no_mcb_for_loopback.html",
+        "browser/base/content/test/siteIdentity/test_no_mcb_for_onions.html",
+        "browser/base/content/test/statuspanel/browser_show_statuspanel_twice.js",
+        "browser/base/content/test/sync/browser_fxa_web_channel.js",
+        "browser/base/content/test/tabMediaIndicator/head.js",
+        "browser/base/content/test/tabPrompts/browser_beforeunload_urlbar.js",
+        "browser/base/content/test/tabPrompts/browser_confirmFolderUpload.js",
+        "browser/base/content/test/tabPrompts/browser_contentOrigins.js",
+        "browser/base/content/test/tabPrompts/browser_multiplePrompts.js",
+        "browser/base/content/test/tabPrompts/browser_openPromptInBackgroundTab.js",
+        "browser/base/content/test/tabPrompts/browser_promptFocus.js",
+        "browser/base/content/test/tabcrashed/browser_launchFail.js",
+        "browser/base/content/test/tabcrashed/browser_multipleCrashedTabs.js",
+        "browser/base/content/test/tabcrashed/browser_printpreview_crash.js",
+        "browser/base/content/test/tabcrashed/browser_shownRestartRequired.js",
+        "browser/base/content/test/tabcrashed/head.js",
+        "browser/base/content/test/tabdialogs/browser_subdialog_esc.js",
+        "browser/base/content/test/tabdialogs/browser_tabdialogbox_content_prompts.js",
+        "browser/base/content/test/tabdialogs/browser_tabdialogbox_focus.js",
+        "browser/base/content/test/tabdialogs/browser_tabdialogbox_navigation.js",
+        "browser/base/content/test/tabs/browser_close_during_beforeunload.js",
+        "browser/base/content/test/tabs/browser_contextmenu_openlink_after_tabnavigated.js",
+        "browser/base/content/test/tabs/browser_e10s_switchbrowser.js",
+        "browser/base/content/test/tabs/browser_lazy_tab_browser_events.js",
+        "browser/base/content/test/tabs/browser_multiselect_tabs_bookmark.js",
+        "browser/base/content/test/tabs/browser_multiselect_tabs_copy_through_drag_and_drop.js",
+        "browser/base/content/test/tabs/browser_multiselect_tabs_duplicate.js",
+        "browser/base/content/test/tabs/browser_multiselect_tabs_move_to_new_window_contextmenu.js",
+        "browser/base/content/test/tabs/browser_multiselect_tabs_open_related.js",
+        "browser/base/content/test/tabs/browser_navigatePinnedTab.js",
+        "browser/base/content/test/tabs/browser_new_file_whitelisted_http_tab.js",
+        "browser/base/content/test/tabs/browser_new_tab_in_privilegedabout_process_pref.js",
+        "browser/base/content/test/tabs/browser_new_tab_insert_position.js",
+        "browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js",
+        "browser/base/content/test/tabs/browser_privilegedmozilla_process_pref.js",
+        "browser/base/content/test/tabs/browser_progress_keyword_search_handling.js",
+        "browser/base/content/test/tabs/browser_replacewithwindow_commands.js",
+        "browser/base/content/test/tabs/browser_undo_close_tabs.js",
+        "browser/base/content/test/webrtc/browser_devices_get_user_media.js",
+        "browser/base/content/test/zoom/browser_background_link_zoom_reset.js",
+        "browser/base/content/test/zoom/browser_background_zoom.js",
+        "browser/base/content/test/zoom/browser_default_zoom_multitab.js",
+        "browser/base/content/test/zoom/browser_default_zoom_multitab_002.js",
+        "browser/base/content/test/zoom/browser_image_zoom_tabswitch.js",
+        "browser/base/content/test/zoom/browser_mousewheel_zoom.js",
+        "browser/base/content/test/zoom/browser_sitespecific_background_pref.js",
+        "browser/base/content/test/zoom/browser_sitespecific_video_zoom.js",
+        "browser/base/content/test/zoom/browser_subframe_textzoom.js",
+        "browser/base/content/test/zoom/browser_tabswitch_zoom_flicker.js",
         "browser/components/aboutlogins/tests/browser/browser_createLogin.js",
         "browser/components/aboutlogins/tests/chrome/test_login_item.html",
         "browser/components/contextualidentity/test/browser/browser_broadcastchannel.js",

browser/base/content/test/about/browser_aboutHome_search_POST.js

@@ -54,7 +54,6 @@ add_task(async function() {
       let engine;
       await promiseContentSearchChange(browser, async () => {
         Services.search.addOpenSearchEngine(
-          // eslint-disable-next-line @microsoft/sdl/no-insecure-url
           "http://test:80/browser/browser/base/content/test/about/POSTSearchEngine.xml",
           null
         );

browser/base/content/test/about/browser_aboutNetError.js

@@ -162,7 +162,6 @@ add_task(async function checkDomainCorrection() {
   info("Try loading a URI that should result in an error page");
   BrowserTestUtils.openNewForegroundTab(
     gBrowser,
-    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example/example2/",
     false
   );

browser/base/content/test/about/browser_aboutNetError_csp_iframe.js

@@ -4,7 +4,6 @@
 "use strict";
 
 const BLOCKED_PAGE =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org:8000/browser/browser/base/content/test/about/csp_iframe.sjs";
 
 add_task(async function test_csp() {
@@ -39,7 +38,6 @@ async function setupPage(htmlPageName, blockedPage) {
   let iFramePage =
     getRootDirectory(gTestPath).replace(
       "chrome://mochitests/content",
-      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       "http://example.com"
     ) + htmlPageName;
 

browser/base/content/test/about/browser_aboutNetError_xfo_iframe.js

@@ -4,7 +4,6 @@
 "use strict";
 
 const BLOCKED_PAGE =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org:8000/browser/browser/base/content/test/about/xfo_iframe.sjs";
 
 add_task(async function test_xfo_iframe() {
@@ -39,7 +38,6 @@ async function setupPage(htmlPageName, blockedPage) {
   let iFramePage =
     getRootDirectory(gTestPath).replace(
       "chrome://mochitests/content",
-      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       "http://example.com"
     ) + htmlPageName;
 

browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarEmpty.js

@@ -6,17 +6,14 @@
 const bookmarksInfo = [
   {
     title: "firefox",
-    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     url: "http://example.com",
   },
   {
     title: "rules",
-    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     url: "http://example.com/2",
   },
   {
     title: "yo",
-    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     url: "http://example.com/2",
   },
 ];

browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarPrefs.js

@@ -58,7 +58,6 @@ add_task(async function test_with_different_pref_states() {
 
       await BrowserTestUtils.openNewForegroundTab({
         gBrowser: win.gBrowser,
-        // eslint-disable-next-line @microsoft/sdl/no-insecure-url
         opening: "http://example.com",
       });
       await waitForBookmarksToolbarVisibility({

browser/base/content/test/alerts/browser_notification_close.js

@@ -9,7 +9,6 @@ const { PermissionTestUtils } = ChromeUtils.import(
 );
 
 let notificationURL =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/alerts/file_dom_notifications.html";
 let oldShowFavicons;
 

browser/base/content/test/alerts/browser_notification_do_not_disturb.js

@@ -14,7 +14,6 @@ const ALERT_SERVICE = Cc["@mozilla.org/alerts-service;1"]
   .QueryInterface(Ci.nsIAlertsDoNotDisturb);
 
 const PAGE =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/alerts/file_dom_notifications.html";
 
 // The amount of time in seconds that we will wait for a notification

browser/base/content/test/alerts/browser_notification_open_settings.js

@@ -1,7 +1,6 @@
 "use strict";
 
 var notificationURL =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/alerts/file_dom_notifications.html";
 var expectedURL = "about:preferences#privacy";
 

browser/base/content/test/alerts/browser_notification_remove_permission.js

@@ -6,7 +6,6 @@ const { PermissionTestUtils } = ChromeUtils.import(
 
 var tab;
 var notificationURL =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/alerts/file_dom_notifications.html";
 var alertWindowClosed = false;
 var permRemoved = false;

browser/base/content/test/alerts/browser_notification_replace.js

@@ -1,7 +1,6 @@
 "use strict";
 
 let notificationURL =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/alerts/file_dom_notifications.html";
 
 add_task(async function test_notificationReplace() {

browser/base/content/test/alerts/browser_notification_tab_switching.js

@@ -11,7 +11,6 @@ const { PermissionTestUtils } = ChromeUtils.import(
 var tab;
 var notification;
 var notificationURL =
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/alerts/file_dom_notifications.html";
 var newWindowOpenedFromTab;