Skip to content

Commit

Permalink
Bug 1766497 - Remove early exit on Homebrew Python3.10 now that we're…
Browse files Browse the repository at this point in the history
… using `venv` instead of `virtualenv` r=firefox-build-system-reviewers,nalexander

Depends on D158922

Differential Revision: https://phabricator.services.mozilla.com/D159196
  • Loading branch information
ahochheiden committed Nov 1, 2022
1 parent fc391c3 commit f166c5e
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions mach
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,6 @@ def main(args):
""").strip())
sys.exit(1)

if sys.version_info >= (3, 10) and sys.platform.startswith("darwin"):
version = f"{sys.version_info[0]}.{sys.version_info[1]}"
if f"python@{version}" in sys.executable:
print(dedent(f"""
You are using python {version} from homebrew.
There is a bug in virtualenv that prevents us from starting up mach in that situation.
Please uninstall it with the following and try again:
brew unlink python@{version}
If you need python {version} later, you can re-link it with:
brew link python@{version}
""").strip())
sys.exit(1)

# XCode python sets __PYVENV_LAUNCHER__, which overrides the executable
# used when a python subprocess is created. This is an issue when we want
# to run using our virtualenv python executables.
Expand Down

0 comments on commit f166c5e

Please sign in to comment.