Skip to content

Commit

Permalink
no bug - doc: minor changes in the levelling up doc + update of the r…
Browse files Browse the repository at this point in the history
…eferences r=devtools-reviewers,nchevobbe

Depends on D194525

Differential Revision: https://phabricator.services.mozilla.com/D194526
  • Loading branch information
sylvestre committed Nov 24, 2023
1 parent 65f2dcf commit f1b98d5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion devtools/docs/contributor/contributing/landing-code.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Leaving potential conflicts aside, a patch can make its way into the repository

## From Phabricator

Once a review has been approved, someone with enough privileges can request the code be merged, using the [Lando](https://moz-conduit.readthedocs.io/en/latest/lando-user.html) interface. These 'privileges' are "commit level access 3". You get these once you have successfully contributed with a number of patches. See [levelling up](./levelling-up.md) for more details.
Once a review has been approved, someone with enough privileges can request the code be merged, using the [Lando](https://moz-conduit.readthedocs.io/en/latest/lando-user.html) interface. These 'privileges' are "commit level access 3". You get these once you have successfully contributed with a number of patches. See [levelling up](https://firefox-source-docs.mozilla.org/contributing/levelling-up.html) for more details.

If you don't have the privileges, you can also ask your mentor to land the code. In fact, they might even initiate that for you once the code review is approved.

Expand Down
2 changes: 1 addition & 1 deletion devtools/docs/contributor/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Contributing
How to fix a bug <contributing/fixing-bugs.md>
Code reviews <contributing/code-reviews.md>
Landing code <contributing/landing-code.md>
Leveling up <contributing/levelling-up.md>
Leveling up <https://firefox-source-docs.mozilla.org/contributing/levelling-up.html>
Coding standards <contributing/coding-standards.md>
Filing good bugs <contributing/filing-good-bugs.md>
Investigating performance issues <contributing/performance.md>
Expand Down
1 change: 1 addition & 0 deletions docs/contributing/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ development process and source code documentation.
pocket-guide-shipping-firefox
editor
reviews
levelling-up

.. toctree::
:caption: The Mercurial Version Control System
Expand Down
10 changes: 4 additions & 6 deletions docs/contributing/levelling-up.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@ page explains what does each level mean.
Request commit access level 1
-----------------------------

Once this is granted, you can use `the ``Try``
server <https://wiki.mozilla.org/ReleaseEngineering/TryServer>`__ for
Once this is granted, you can use the
`Try server <https://wiki.mozilla.org/ReleaseEngineering/TryServer>`__ for
running automated tests of your code.

To request this, `follow the instructions
here <https://www.mozilla.org/en-US/about/governance/policies/commit/>`__
To request this, follow the instructions on the `Becoming A Mozilla Committer <https://www.mozilla.org/en-US/about/governance/policies/commit/>`__ page
to file a bug with the title “Commit Access (Level 1) for ${your name}”,
and continue with steps such as adding the public SSH key, etc (it’s not
enough with just filing the bug!).
Expand All @@ -34,8 +33,7 @@ After you landed a few bugs, that are more advanced than the
well as the process, you can request level 3 access. Once this is
granted, you will get access to Lando, the autoland feature.

To request this, `follow the instructions
here <https://www.mozilla.org/en-US/about/governance/policies/commit/>`__
To request this, follow the instructions on the `Becoming A Mozilla Committer <https://www.mozilla.org/en-US/about/governance/policies/commit/>`__ page
to file a bug with the title “Commit Access (Level 3) for ${your name}”.

The person that asked you to request this can also vouch for you, and at
Expand Down

0 comments on commit f1b98d5

Please sign in to comment.