Bug 1303612 - New console frontend: pageErrors should include the loc…

…ation. r=linclark MozReview-Commit-ID: 4UUOSHYtu4l
dothq · Sep 20, 2016 · f57b5d0 · f57b5d0
1 parent f95d017
commit f57b5d0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/devtools/client/webconsole/new-console-output/components/message-types/page-error.js b/devtools/client/webconsole/new-console-output/components/message-types/page-error.js
@@ -47,7 +47,6 @@ function PageError(props) {
     }) : null
   );
 
-
   let collapse = "";
   let attachment = "";
   if (stacktrace) {
@@ -96,7 +95,8 @@ function PageError(props) {
         dom.span({ className: "message-body devtools-monospace" },
           message.messageText
         ),
-        repeat
+        repeat,
+        location
       ),
       attachment
     )

diff --git a/devtools/client/webconsole/new-console-output/test/components/page-error.test.js b/devtools/client/webconsole/new-console-output/test/components/page-error.test.js
@@ -23,6 +23,12 @@ describe("PageError component:", () => {
     // The stacktrace should be closed by default.
     const frameLinks = wrapper.find(`.stack-trace`);
     expect(frameLinks.length).toBe(0);
+
+    // There should be the location
+    const locationLink = wrapper.find(`.message-location`);
+    expect(locationLink.length).toBe(1);
+    // @TODO Will likely change. See https://github.com/devtools-html/gecko-dev/issues/285
+    expect(locationLink.text()).toBe("http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generato");
   });
 
   it("has a stacktrace which can be openned", () => {