Skip to content

Commit

Permalink
Bug 1867378 - Pt.3. Update the test manifest for Add-ons Manager tabp…
Browse files Browse the repository at this point in the history
…anel cases that are passing a11y-checks. r=extension-reviewers,zombie

When the D195198 would be ready to land, there are a few tests that are going to be passing all a11y-checks since the AccessibilityUtils would be able to automatically check focusable tabs in tablists (that were previously failing these tests) or some of them, thus we need to update the manifest to remove `fail-if`  notations when appropriate and update the comments in the remaining tests

Depends on D195745

Differential Revision: https://phabricator.services.mozilla.com/D197025
  • Loading branch information
anna-yeddi committed Jan 2, 2024
1 parent 83f0502 commit f81f68d
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions toolkit/mozapps/extensions/test/browser/browser.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,12 @@ skip-if = ["true"] # Bug 1626824
["browser_file_xpi_no_process_switch.js"]

["browser_globalwarnings.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.addon-name-container, button.category may not be focusable
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.addon-name-container may not be focusable

["browser_gmpProvider.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.addon-name-container, button.category, div.card.addon, div.container may not be focusable
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.addon-name-container and div.card.addon may not be focusable

["browser_history_navigation.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked button.category may not be focusable
https_first_disabled = true

["browser_html_abuse_report.js"]
Expand All @@ -92,17 +91,15 @@ support-files = ["head_abuse_report.js"]
support-files = ["head_abuse_report.js"]

["browser_html_detail_permissions.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked button#details-deck-button-permissions may not be focusable

["browser_html_detail_view.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.addon-name-container, button.category may not be focusable
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.addon-name-container may not be focusable

["browser_html_discover_view.js"]
https_first_disabled = true
support-files = ["head_disco.js"]

["browser_html_discover_view_clientid.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked button.category may not be focusable

["browser_html_discover_view_prefs.js"]

Expand All @@ -115,26 +112,24 @@ skip-if = ["a11y_checks"] # Bug 1858037 to investigate intermittent a11y_checks
["browser_html_message_bar.js"]

["browser_html_options_ui.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked button.details-deck-button-details, button.details-deck-button-preferences may not be focusable

["browser_html_options_ui_in_tab.js"]

["browser_html_pending_updates.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.text-container, button.category may not be focusable
fail-if = ["a11y_checks"] # Bug 1854646 clicked div.text-container may not be focusable

["browser_html_recent_updates.js"]

["browser_html_recommendations.js"]
https_first_disabled = true

["browser_html_scroll_restoration.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked button#details-deck-button-permissions may not be focusable
skip-if = ["os == 'mac' && verify && debug"] # Bug 1850159

["browser_html_sitepermission_addons.js"]

["browser_html_updates.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked div, button.details-deck-button-details, button.details-deck-button-release-notes, button.category may not be focusable
fail-if = ["a11y_checks"] # Bug 1854646 clicked div may not be focusable
https_first_disabled = true

["browser_html_warning_messages.js"]
Expand All @@ -150,7 +145,7 @@ https_first_disabled = true
["browser_manage_shortcuts_hidden.js"]

["browser_manage_shortcuts_remove.js"]
fail-if = ["a11y_checks"] # Bug 1854646 clicked element may not be focusable
fail-if = ["a11y_checks"] # Bug 1854646 clicked button.shortcut-remove-button may not be labeled

["browser_menu_button_accessibility.js"]

Expand Down

0 comments on commit f81f68d

Please sign in to comment.