Bug 1791682 - [3/3] Remove thread names only used in tests r=andi

Remove all the thread names only used in tests from ThreadAllows.txt.
Instead, list the test files that create them in ThreadFileAllows.txt.

Differential Revision: https://phabricator.services.mozilla.com/D157762

build/clang-plugin/ThreadAllows.txt

@@ -36,14 +36,6 @@ Checker Test  # used only as part of tests for the thread-checker itself
 # In particular, if a thread name is only used for testing, please consider
 # moving its declarator to `ThreadFileAllows.txt`.
 
-ApplyUpdates
-AsyncShutdownPr
-AsyncShutdownWt
-Atom Test
-AutoRefCnt Test
-AutoTestThread
-AwaitIdleMixed
-AwaitIdlePaused
 BGReadURLs
 BHMgr Monitor
 BHMgr Processor
@@ -52,37 +44,28 @@ COM MTA
 Cache I/O
 Cameras IPC
 CanvasRenderer
-ChainedPipePump
-ChainedPipeRecv
 Compositor
 Cookie
 CrashRep Inject
 DDMediaLogs
 DOMCacheThread
 DataChannel IO
 DataStorage
-DatabaseLocker
-DecodeToSurface
-Decoder Test
 FileWatcher IO
 Font Loader
 FontEnumThread
 Function Broker
 GMPThread
 Gamepad
-GeckoProfGTest
 GraphRunner
 HTML5 Parser
 ICS parser
 IPC Launch
-IPCFuzzLoop
 IPDL Background
-IPDL UnitTest
 IdentityCrypto
 ImageBridgeChld
 LS Thread
 MDCDMThread
-MWQThread
 MediaCache
 MediaTelemetry
 MediaTrackGrph
@@ -100,28 +83,16 @@ ProfSymbolTable
 ProfilerChild
 ProxyResolution
 RemoteLzyStream
-RWLockTester
-RacingServMan
 RemVidChild
 Renderer
 ResetCleanup
-Sandbox Testing
 SaveScripts
 Socket Thread
 SpeechWorker
-SpinEventLoop
 StressRunner
 SuicideManager
-SuicideThread
 System Proxy
-TEQ AwaitIdle
 TelemetryModule
-Test Thread
-Test thread
-TestPipe
-TestShortWrites
-TestThreadsMain
-Testing Thread
 Timer
 ToastBgThread
 TRR Background
@@ -132,8 +103,6 @@ VsyncIOThread
 Wifi Monitor
 Worker Launcher
 speechd init
-t1
-t2
 thread
 thread shutdown
 wifi tickler

build/clang-plugin/ThreadFileAllows.txt

@@ -20,7 +20,15 @@ xpcom/threads/nsThreadUtils.cpp
 xpcom/threads/nsThreadPool.cpp
 
 ######
-# Unsorted files
+# Test files
+
+# Tests for XPCOM threads themselves.
+xpcom/tests/gtest/TestThreadManager.cpp
+xpcom/tests/gtest/TestThreads.cpp
+xpcom/tests/gtest/TestThreadUtils.cpp
+
+######
+# Unsorted release files
 #
 # Files below this point are grandfathered in. Please do not add new files to
 # this list -- and please remove any that you can, whether by documenting and
@@ -34,3 +42,31 @@ LazyIdleThread.h
 VRThread.cpp
 mozStorageConnection.cpp
 nr_socket_prsock.cpp
+
+######
+# Unsorted test files
+#
+# Files below this point are quasi-grandfathered in: these are test files which
+# create new threads whose names were formerly in ThreadAllows.txt (without
+# justification), and have been moved here (without justification).
+dom/media/doctor/test/gtest/TestMultiWriterQueue.cpp
+image/test/fuzzing/TestDecoders.cpp
+image/test/gtest/TestDecodeToSurface.cpp
+ipc/ipdl/test/gtest/IPDLUnitTest.cpp
+security/sandbox/common/test/SandboxTestingThread.h
+storage/test/gtest/test_interruptSynchronousConnection.cpp
+storage/test/gtest/test_unlock_notify.cpp
+toolkit/components/telemetry/geckoview/gtest/TestGeckoViewStreaming.cpp
+toolkit/components/telemetry/tests/gtest/TestScalars.cpp
+toolkit/components/url-classifier/tests/gtest/Common.cpp
+tools/fuzzing/ipc/IPCFuzzController.cpp
+tools/profiler/tests/gtest/GeckoProfiler.cpp
+xpcom/tests/gtest/TestAtoms.cpp
+xpcom/tests/gtest/TestAutoRefCnt.cpp
+xpcom/tests/gtest/TestDelayedRunnable.cpp
+xpcom/tests/gtest/TestLogging.cpp
+xpcom/tests/gtest/TestPipes.cpp
+xpcom/tests/gtest/TestRacingServiceManager.cpp
+xpcom/tests/gtest/TestRWLock.cpp
+xpcom/tests/gtest/TestThrottledEventQueue.cpp
+xpcom/tests/gtest/TestTimers.cpp