Skip to content

Commit

Permalink
Bug 1654994 - Make full symbols archive opt-in rather than opt-out. r…
Browse files Browse the repository at this point in the history
…=froydnj

Differential Revision: https://phabricator.services.mozilla.com/D85354
  • Loading branch information
glandium committed Jul 30, 2020
1 parent a496811 commit fb02e02
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,13 @@ symbolsarchive: prepsymbolsarchive
$(abspath $(DIST)/crashreporter-symbols))

ifdef MOZ_CRASHREPORTER
# Set MOZ_DISABLE_FULL_SYMBOLS to disable generation and upload of the full
# Set MOZ_ENABLE_FULL_SYMBOLS to enable generation and upload of the full
# crashreporter symbols archives
ifdef MOZ_DISABLE_FULL_SYMBOLS
buildsymbols: symbolsarchive
else
ifdef MOZ_ENABLE_FULL_SYMBOLS
buildsymbols: symbolsfullarchive symbolsarchive
endif # MOZ_DISABLE_FULL_SYMBOLS
else
buildsymbols: symbolsarchive
endif # MOZ_ENABLE_FULL_SYMBOLS
else
buildsymbols:
endif
Expand Down
2 changes: 1 addition & 1 deletion build/mozconfig.artifact
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Enable the artifact build.
ac_add_options --enable-artifact-builds
if test -n "$MOZ_ARTIFACT_TASK_WIN32_OPT" -a -z "$MOZ_DISABLE_FULL_SYMBOLS"; then
if test -n "$MOZ_ARTIFACT_TASK_WIN32_OPT" -a -n "$MOZ_ENABLE_FULL_SYMBOLS"; then
ac_add_options --enable-artifact-build-symbols=full
else
ac_add_options --enable-artifact-build-symbols
Expand Down
2 changes: 1 addition & 1 deletion taskcluster/taskgraph/transforms/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ def enable_full_crashsymbols(config, jobs):
enable_full_crashsymbols = job['attributes'].get('enable-full-crashsymbols')
if enable_full_crashsymbols and config.params['project'] in branches:
logger.debug("Enabling full symbol generation for %s", job['name'])
job['worker']['env']['MOZ_ENABLE_FULL_SYMBOLS'] = '1'
else:
logger.debug("Disabling full symbol generation for %s", job['name'])
job['worker']['env']['MOZ_DISABLE_FULL_SYMBOLS'] = '1'
job['attributes'].pop('enable-full-crashsymbols', None)
yield job

0 comments on commit fb02e02

Please sign in to comment.