Skip to content

Commit

Permalink
Merge m-c to m-i
Browse files Browse the repository at this point in the history
  • Loading branch information
philor committed Mar 21, 2015
2 parents 33f4dd4 + 9ef50f3 commit fc8b8ab
Show file tree
Hide file tree
Showing 50 changed files with 631 additions and 359 deletions.
4 changes: 2 additions & 2 deletions b2g/config/dolphin/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<project name="platform_build" path="build" remote="b2g" revision="ef937d1aca7c4cf89ecb5cc43ae8c21c2000a9db">
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="librecovery" path="librecovery" remote="b2g" revision="1b3591a50ed352fc6ddb77462b7b35d0bfa555a3"/>
Expand Down Expand Up @@ -138,7 +138,7 @@
<project name="platform/system/core" path="system/core" revision="a626f6c0ef9e88586569331bd7387b569eaa5ed2"/>
<project name="u-boot" path="u-boot" revision="f1502910977ac88f43da7bf9277c3523ad4b0b2f"/>
<project name="vendor/sprd/gps" path="vendor/sprd/gps" revision="4c59900937dc2e978b7b14b7f1ea617e3d5d550e"/>
<project name="vendor/sprd/open-source" path="vendor/sprd/open-source" revision="8a81f598126f4153b80c1a2425343174b6cffd79"/>
<project name="vendor/sprd/open-source" path="vendor/sprd/open-source" revision="c5206aa084ad36037b8ee4b405a71ec7bd88b41c"/>
<project name="vendor/sprd/partner" path="vendor/sprd/partner" revision="8649c7145972251af11b0639997edfecabfc7c2e"/>
<project name="vendor/sprd/proprietories" path="vendor/sprd/proprietories" revision="d2466593022f7078aaaf69026adf3367c2adb7bb"/>
</manifest>
2 changes: 1 addition & 1 deletion b2g/config/emulator-ics/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="fake-dalvik" path="dalvik" remote="b2g" revision="ca1f327d5acc198bb4be62fa51db2c039032c9ce"/>
<project name="gaia.git" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia.git" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="rilproxy" path="rilproxy" remote="b2g" revision="5ef30994f4778b4052e58a4383dbe7890048c87e"/>
<project name="platform_hardware_ril" path="hardware/ril" remote="b2g" revision="93f9ba577f68d772093987c2f1c0a4ae293e1802"/>
Expand Down
2 changes: 1 addition & 1 deletion b2g/config/emulator-jb/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</project>
<project name="rilproxy" path="rilproxy" remote="b2g" revision="5ef30994f4778b4052e58a4383dbe7890048c87e"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="moztt" path="external/moztt" remote="b2g" revision="ed2cf97a6c37a4bbd0bbbbffe06ec7136d8c79ff"/>
<project name="apitrace" path="external/apitrace" remote="apitrace" revision="b685e3aab4fde7624d78993877a8f7910f2a5f06"/>
Expand Down
2 changes: 1 addition & 1 deletion b2g/config/emulator-kk/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<project name="platform_build" path="build" remote="b2g" revision="ef937d1aca7c4cf89ecb5cc43ae8c21c2000a9db">
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="librecovery" path="librecovery" remote="b2g" revision="1b3591a50ed352fc6ddb77462b7b35d0bfa555a3"/>
Expand Down
4 changes: 2 additions & 2 deletions b2g/config/emulator-l/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<project name="platform_build" path="build" remote="b2g" revision="52775e03a2d8532429dff579cb2cd56718e488c3">
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="librecovery" path="librecovery" remote="b2g" revision="1b3591a50ed352fc6ddb77462b7b35d0bfa555a3"/>
Expand Down Expand Up @@ -124,7 +124,7 @@
<project name="platform/ndk" path="ndk" revision="869c05cab7b4315c2bc607493db3f5b18ead2580"/>
<project name="platform_prebuilts_misc" path="prebuilts/misc" remote="b2g" revision="da8b660db117e2a69a7624bfdca2f02cad397f2e"/>
<project name="platform/prebuilts/ndk" path="prebuilts/ndk" revision="5fd638a4a0ff3677fc3c970fab038d6db1bb7665"/>
<project name="platform/prebuilts/qemu-kernel" path="prebuilts/qemu-kernel" revision="530cad9b205442d2db29361e796299dc323ef9ce"/>
<project name="platform_prebuilts_qemu-kernel" path="prebuilts/qemu-kernel" remote="b2g" revision="2c0d193349c55337e37196a7f2d5cef37753ed3e"/>
<project name="platform/prebuilts/sdk" path="prebuilts/sdk" revision="a982f43b7f2d5916dc3a859667a8ba78e50b6202"/>
<project name="platform/prebuilts/tools" path="prebuilts/tools" revision="6e18b61ee446bdd9880c07ae84197a087490c2e5"/>
<project name="platform_system_bluetoothd" path="system/bluetoothd" remote="b2g" revision="e0fc03e0a3062063c3c85996dcc881c0a49ed98d"/>
Expand Down
2 changes: 1 addition & 1 deletion b2g/config/emulator/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="fake-dalvik" path="dalvik" remote="b2g" revision="ca1f327d5acc198bb4be62fa51db2c039032c9ce"/>
<project name="gaia.git" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia.git" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="rilproxy" path="rilproxy" remote="b2g" revision="5ef30994f4778b4052e58a4383dbe7890048c87e"/>
<project name="platform_hardware_ril" path="hardware/ril" remote="b2g" revision="93f9ba577f68d772093987c2f1c0a4ae293e1802"/>
Expand Down
2 changes: 1 addition & 1 deletion b2g/config/flame-kk/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<project name="platform_build" path="build" remote="b2g" revision="ef937d1aca7c4cf89ecb5cc43ae8c21c2000a9db">
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="librecovery" path="librecovery" remote="b2g" revision="1b3591a50ed352fc6ddb77462b7b35d0bfa555a3"/>
Expand Down
2 changes: 1 addition & 1 deletion b2g/config/flame/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</project>
<project name="librecovery" path="librecovery" remote="b2g" revision="1b3591a50ed352fc6ddb77462b7b35d0bfa555a3"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="moztt" path="external/moztt" remote="b2g" revision="ed2cf97a6c37a4bbd0bbbbffe06ec7136d8c79ff"/>
<project name="apitrace" path="external/apitrace" remote="apitrace" revision="b685e3aab4fde7624d78993877a8f7910f2a5f06"/>
Expand Down
4 changes: 2 additions & 2 deletions b2g/config/gaia.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"git": {
"git_revision": "66558ce7f36809a20d1c721fd4d457913b09c5c7",
"git_revision": "c8aecdd05ddc11013945923b8d5fa4df077e56a0",
"remote": "https://git.mozilla.org/releases/gaia.git",
"branch": ""
},
"revision": "73b67adb48cdfbba7a520d3499e9759757c8b3c5",
"revision": "78b760e2859cb7504f864aa96a5b98748ae1bbb6",
"repo_path": "integration/gaia-central"
}
2 changes: 1 addition & 1 deletion b2g/config/nexus-4/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</project>
<project name="rilproxy" path="rilproxy" remote="b2g" revision="5ef30994f4778b4052e58a4383dbe7890048c87e"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="moztt" path="external/moztt" remote="b2g" revision="ed2cf97a6c37a4bbd0bbbbffe06ec7136d8c79ff"/>
<project name="apitrace" path="external/apitrace" remote="apitrace" revision="b685e3aab4fde7624d78993877a8f7910f2a5f06"/>
Expand Down
4 changes: 2 additions & 2 deletions b2g/config/nexus-5-l/sources.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<project name="platform_build" path="build" remote="b2g" revision="52775e03a2d8532429dff579cb2cd56718e488c3">
<copyfile dest="Makefile" src="core/root.mk"/>
</project>
<project name="gaia" path="gaia" remote="mozillaorg" revision="66558ce7f36809a20d1c721fd4d457913b09c5c7"/>
<project name="gaia" path="gaia" remote="mozillaorg" revision="c8aecdd05ddc11013945923b8d5fa4df077e56a0"/>
<project name="fake-libdvm" path="dalvik" remote="b2g" revision="d50ae982b19f42f0b66d08b9eb306be81687869f"/>
<project name="gonk-misc" path="gonk-misc" remote="b2g" revision="86cd7486d8e50eaac8ef6fe2f51f09d25194577b"/>
<project name="librecovery" path="librecovery" remote="b2g" revision="1b3591a50ed352fc6ddb77462b7b35d0bfa555a3"/>
Expand Down Expand Up @@ -124,7 +124,7 @@
<project name="platform/ndk" path="ndk" revision="869c05cab7b4315c2bc607493db3f5b18ead2580"/>
<project name="platform_prebuilts_misc" path="prebuilts/misc" remote="b2g" revision="da8b660db117e2a69a7624bfdca2f02cad397f2e"/>
<project name="platform/prebuilts/ndk" path="prebuilts/ndk" revision="5fd638a4a0ff3677fc3c970fab038d6db1bb7665"/>
<project name="platform/prebuilts/qemu-kernel" path="prebuilts/qemu-kernel" revision="530cad9b205442d2db29361e796299dc323ef9ce"/>
<project name="platform_prebuilts_qemu-kernel" path="prebuilts/qemu-kernel" remote="b2g" revision="2c0d193349c55337e37196a7f2d5cef37753ed3e"/>
<project name="platform/prebuilts/sdk" path="prebuilts/sdk" revision="a982f43b7f2d5916dc3a859667a8ba78e50b6202"/>
<project name="platform/prebuilts/tools" path="prebuilts/tools" revision="6e18b61ee446bdd9880c07ae84197a087490c2e5"/>
<project name="platform_system_bluetoothd" path="system/bluetoothd" remote="b2g" revision="e0fc03e0a3062063c3c85996dcc881c0a49ed98d"/>
Expand Down
1 change: 1 addition & 0 deletions browser/app/profile/firefox.js
Original file line number Diff line number Diff line change
Expand Up @@ -1881,5 +1881,6 @@ pref("reader.parse-on-load.enabled", false);

// Disable ReadingList browser UI by default.
pref("browser.readinglist.enabled", false);
pref("browser.readinglist.sidebarEverOpened", false);
// Enable the readinglist engine by default.
pref("readinglist.scheduler.enabled", true);
21 changes: 18 additions & 3 deletions browser/base/content/browser-readinglist.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ let ReadingListUI = {
});

target.insertBefore(menuitem, insertPoint);
});
}, {sort: "addedOn", descending: true});

if (!hasItems) {
let menuitem = document.createElement("menuitem");
Expand Down Expand Up @@ -242,12 +242,20 @@ let ReadingListUI = {
uri = null;
}

let msg = {topic: "UpdateActiveItem", url: null};
if (!uri) {
this.toolbarButton.setAttribute("hidden", true);
if (this.isSidebarOpen)
document.getElementById("sidebar").contentWindow.postMessage(msg, "*");
return;
}

let isInList = yield ReadingList.containsURL(uri);
let isInList = yield ReadingList.hasItemForURL(uri);
if (this.isSidebarOpen) {
if (isInList)
msg.url = typeof uri == "string" ? uri : uri.spec;
document.getElementById("sidebar").contentWindow.postMessage(msg, "*");
}
this.setToolbarButtonState(isInList);
}),

Expand Down Expand Up @@ -284,7 +292,7 @@ let ReadingListUI = {
if (!uri)
return;

let item = yield ReadingList.getItemForURL(uri);
let item = yield ReadingList.itemForURL(uri);
if (item) {
yield item.delete();
} else {
Expand Down Expand Up @@ -315,8 +323,15 @@ let ReadingListUI = {
* @param {ReadingListItem} item - Item added.
*/
onItemAdded(item) {
if (!Services.prefs.getBoolPref("browser.readinglist.sidebarEverOpened")) {
SidebarUI.show("readingListSidebar");
}
if (this.isItemForCurrentBrowser(item)) {
this.setToolbarButtonState(true);
if (this.isSidebarOpen) {
let msg = {topic: "UpdateActiveItem", url: item.url};
document.getElementById("sidebar").contentWindow.postMessage(msg, "*");
}
}
},

Expand Down
1 change: 0 additions & 1 deletion browser/base/content/browser.css
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,6 @@ chatbox {

chatbox[large="true"] {
width: 300px;
heigth: 272px;
}

chatbox[minimized="true"] {
Expand Down
6 changes: 4 additions & 2 deletions browser/base/content/newtab/grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ let gGrid = {
' class="newtab-control newtab-control-pin"/>' +
'<input type="button" title="' + newTabString("block") + '"' +
' class="newtab-control newtab-control-block"/>' +
'<span class="newtab-sponsored">' + newTabString("sponsored.button") + '</span>';
'<span class="newtab-sponsored">' + newTabString("sponsored.button") + '</span>' +
'<span class="newtab-suggested"/>';

this._siteFragment = document.createDocumentFragment();
this._siteFragment.appendChild(site);
Expand All @@ -189,7 +190,8 @@ let gGrid = {
// Save the cell's computed height/width including margin and border
if (this._cellMargin === undefined) {
let refCell = document.querySelector(".newtab-cell");
this._cellMargin = parseFloat(getComputedStyle(refCell).marginTop) * 2;
this._cellMargin = parseFloat(getComputedStyle(refCell).marginTop) +
parseFloat(getComputedStyle(refCell).marginBottom);
this._cellHeight = refCell.offsetHeight + this._cellMargin;
this._cellWidth = refCell.offsetWidth + this._cellMargin;
}
Expand Down
45 changes: 39 additions & 6 deletions browser/base/content/newtab/newTab.css
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ input[type=button] {
.newtab-cell {
display: -moz-box;
height: 180px;
margin: 20px 10px;
margin: 20px 10px 85px;
width: 290px;
}

Expand Down Expand Up @@ -193,20 +193,45 @@ input[type=button] {

/* TITLES */
.newtab-sponsored,
.newtab-title {
bottom: -26px;
.newtab-title,
.newtab-suggested {
overflow: hidden;
position: absolute;
right: 0;
text-align: center;
white-space: nowrap;
}

.newtab-sponsored,
.newtab-title {
bottom: -26px;
white-space: nowrap;
text-overflow: ellipsis;
font-size: 13px;
}

.newtab-suggested {
border: 1px solid #dcdcdc;
border-radius: 2px;
cursor: pointer;
font-size: 12px;
height: 17px;
line-height: 17px;
margin-bottom: -1px;
padding: 2px 8px;
display: none;
margin-left: auto;
margin-right: auto;
left: 0;
top: 215px;
}

.newtab-suggested-bounds {
max-height: 51px; /* 51 / 17 = 3 lines maximum */
}

.newtab-title {
left: 0;
padding-top: 14px;
text-overflow: ellipsis;
}

.newtab-sponsored {
Expand Down Expand Up @@ -237,6 +262,10 @@ input[type=button] {
display: block;
}

.newtab-site[type=related] .newtab-suggested {
display: table;
}

.sponsored-explain,
.sponsored-explain a {
color: white;
Expand Down Expand Up @@ -462,7 +491,7 @@ input[type=button] {
.newtab-customize-panel-item,
.newtab-search-panel-engine,
#newtab-search-manage {
padding: 4px 24px;
padding: 10px 10px 10px 25px;
}

.newtab-customize-panel-item:not(:last-child),
Expand All @@ -484,6 +513,10 @@ input[type=button] {
margin: 0;
}

.newtab-customize-panel-item:not([selected]) {
color: #919191;
}

.newtab-customize-panel-item[selected],
.newtab-search-panel-engine[selected] {
background: url("chrome://global/skin/menu/shared-menu-check.png") center left 4px no-repeat transparent;
Expand Down
6 changes: 3 additions & 3 deletions browser/base/content/newtab/newTab.xul
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@
<xul:panel id="newtab-customize-panel" orient="vertical" type="arrow"
noautohide="true" hidden="true">
<xul:hbox id="newtab-customize-enhanced" class="newtab-customize-panel-item">
<xul:label>&newtab.customize.enhanced;</xul:label>
<xul:label>&newtab.customize.suggested;</xul:label>
</xul:hbox>
<xul:hbox id="newtab-customize-classic" class="newtab-customize-panel-item">
<xul:label>&newtab.customize.classic;</xul:label>
<xul:label>&newtab.customize.topsites;</xul:label>
</xul:hbox>
<xul:hbox id="newtab-customize-blank" class="newtab-customize-panel-item">
<xul:label>&newtab.customize.blank;</xul:label>
<xul:label>&newtab.customize.blank2;</xul:label>
</xul:hbox>
</xul:panel>

Expand Down
33 changes: 26 additions & 7 deletions browser/base/content/newtab/sites.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,12 @@ Site.prototype = {
this._querySelector(".newtab-title").textContent = title;
this.node.setAttribute("type", this.link.type);

if (this.link.targetedSite) {
let targetedSite = `<strong> ${this.link.targetedSite} </strong>`;
this._querySelector(".newtab-suggested").innerHTML =
`<div class='newtab-suggested-bounds'> ${newTabString("suggested.button", [targetedSite])} </div>`;
}

if (this.isPinned())
this._updateAttributes(true);
// Capture the page if the thumbnail is missing, which will cause page.js
Expand Down Expand Up @@ -177,6 +183,15 @@ Site.prototype = {
}
},

_ignoreHoverEvents: function(element) {
element.addEventListener("mouseover", () => {
this.cell.node.setAttribute("ignorehover", "true");
});
element.addEventListener("mouseout", () => {
this.cell.node.removeAttribute("ignorehover");
});
},

/**
* Adds event handlers for the site and its buttons.
*/
Expand All @@ -186,14 +201,12 @@ Site.prototype = {
this._node.addEventListener("dragend", this, false);
this._node.addEventListener("mouseover", this, false);

// Specially treat the sponsored icon to prevent regular hover effects
// Specially treat the sponsored icon & suggested explanation
// text to prevent regular hover effects
let sponsored = this._querySelector(".newtab-sponsored");
sponsored.addEventListener("mouseover", () => {
this.cell.node.setAttribute("ignorehover", "true");
});
sponsored.addEventListener("mouseout", () => {
this.cell.node.removeAttribute("ignorehover");
});
let suggested = this._querySelector(".newtab-suggested");
this._ignoreHoverEvents(sponsored);
this._ignoreHoverEvents(suggested);
},

/**
Expand Down Expand Up @@ -268,6 +281,12 @@ Site.prototype = {
}
// Only handle primary clicks for the remaining targets
else if (button == 0) {
if (target.parentElement.classList.contains("newtab-suggested") ||
target.classList.contains("newtab-suggested")) {
// Suggested explanation text should do nothing when clicked and
// the link in the suggested explanation should act as default.
return;
}
aEvent.preventDefault();
if (target.classList.contains("newtab-control-block")) {
this.block();
Expand Down
4 changes: 2 additions & 2 deletions browser/base/content/test/newtab/browser_newtab_drag_drop.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ function runTests() {
yield addNewTabPageTab();
checkGrid("0,1,2,3,4,5,6,7p,8p");

yield simulateDrop(2, 8);
checkGrid("0,1,3,4,5,6,7p,8p,2p");
yield simulateDrop(2, 5);
checkGrid("0,1,3,4,5,2p,6,7p,8p");

// make sure that pinned sites are re-positioned correctly
yield setLinks("0,1,2,3,4,5,6,7,8");
Expand Down
Loading

0 comments on commit fc8b8ab

Please sign in to comment.