Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Prepare license and other files for the repo consolidation #41912

Merged
merged 2 commits into from
Oct 19, 2019

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Oct 19, 2019

  • The /*.md filter isn't working in AzDO, therefore we are listening the excluded files manually.
  • Renaming CODE_OF_CONDUCT.md to CODE-OF-CONDUCT.TXT to be consistent with THIRD-PARTY-NOTICES.TXT
  • Rename LICENSE.TXT to LICENSE so that GH picks it up correctly and to align it with core-setup.

@ViktorHofer ViktorHofer self-assigned this Oct 19, 2019
@ViktorHofer ViktorHofer force-pushed the ViktorHofer-patch-1 branch 2 times, most recently from 439ee20 to 99188ae Compare October 19, 2019 10:40
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub stephentoub merged commit 0cee444 into master Oct 19, 2019
@stephentoub stephentoub deleted the ViktorHofer-patch-1 branch October 19, 2019 12:09
@ViktorHofer
Copy link
Member Author

Unfortunately it's the PATENTS.TXT file which makes GH not honor our LICENSE file-

GH is using licensee to detect the license in the repo. I just followed the docs to find out why it's still not detecting the license: https://github.com/licensee/licensee/blob/master/docs/CONTRIBUTING.md#reporting-an-improperly-detected-license

It seems that the duplicate license in README.md is confusing the tool:

vihofer@DESKTOP-803H9R0:~/licensee$ script/git-repo https://github.com/dotnet/corefx
License:        NOASSERTION
Matched files:  LICENSE, PATENTS.TXT, README.md
LICENSE:
  Content hash:  d64f3bb4282a97b37454b5bb96a8a264a3363dc3
  Attribution:   Copyright (c) .NET Foundation and Contributors
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       MIT
PATENTS.TXT:
  Content hash:  fab2cb8362aea178cb0953521a67d438862fd7cc
  License:       NOASSERTION
  Closest non-matching licenses:
    MS-PL similarity:  32.28%
README.md:
  Content hash:  b626825aaa1222a80b528e83c2e7fee352c7544d
  Confidence:    90.00%
  Matcher:       Licensee::Matchers::Reference
  License:       MIT

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 19, 2019

In my fork I removed that file and it now identifies the repo correctly as MIT: https://github.com/ViktorHofer/corefx/tree/master

@ViktorHofer
Copy link
Member Author

@richlander @terrajobst @jkotas do we actually need the PATENS.TXT file? I don't see in core-setup or msbuild or other dotnet repos.

@ViktorHofer
Copy link
Member Author

cc @danmosemsft

@richlander
Copy link
Member

The patents.txt is only for a repo that has CoreCLR in it. That's been dotnet/coreclr. After repo consolidation, it's whichever repo has CoreCLR. HTH.

@karelz karelz added this to the 5.0 milestone Dec 19, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…refx#41912)

* Update .azure-ci.yml

* Rename LICENSE.TXT to LICENSE and others


Commit migrated from dotnet/corefx@0cee444
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants