-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Prepare license and other files for the repo consolidation #41912
Conversation
ViktorHofer
commented
Oct 19, 2019
•
edited
Loading
edited
- The /*.md filter isn't working in AzDO, therefore we are listening the excluded files manually.
- Renaming CODE_OF_CONDUCT.md to CODE-OF-CONDUCT.TXT to be consistent with THIRD-PARTY-NOTICES.TXT
- Rename LICENSE.TXT to LICENSE so that GH picks it up correctly and to align it with core-setup.
439ee20
to
99188ae
Compare
99188ae
to
b126d3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @richlander
Unfortunately it's the PATENTS.TXT file which makes GH not honor our LICENSE file- GH is using licensee to detect the license in the repo. I just followed the docs to find out why it's still not detecting the license: https://github.com/licensee/licensee/blob/master/docs/CONTRIBUTING.md#reporting-an-improperly-detected-license It seems that the duplicate license in README.md is confusing the tool:
|
In my fork I removed that file and it now identifies the repo correctly as MIT: https://github.com/ViktorHofer/corefx/tree/master |
@richlander @terrajobst @jkotas do we actually need the PATENS.TXT file? I don't see in core-setup or msbuild or other dotnet repos. |
cc @danmosemsft |
The patents.txt is only for a repo that has CoreCLR in it. That's been dotnet/coreclr. After repo consolidation, it's whichever repo has CoreCLR. HTH. |
…refx#41912) * Update .azure-ci.yml * Rename LICENSE.TXT to LICENSE and others Commit migrated from dotnet/corefx@0cee444