Libraries testing #178
Merged
Libraries testing #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Nov 21, 2019
Unfortunately that wasn't possible. I had to rewrite a chunk of the existing code and inlined couple places into existing code. |
|
Can you point out the diffs? |
|
Not touched and just moved:
Partially touched:
Others are new. |
|
There seems to be an issue with the default references that I need to resolve. |
The existing package Microsoft.DotNet.CoreFxTesting lived in Arcade because of no infrastructure being available to compile local tasks in the repository. As the runtime repository now offers that we can inline the testing framework.
|
This should be ready now. |
safern
reviewed
Nov 21, 2019
safern
reviewed
Nov 21, 2019
ericstj
requested changes
Nov 21, 2019
ericstj
approved these changes
Nov 21, 2019
safern
reviewed
Nov 21, 2019
| @@ -130,5 +130,9 @@ | |||
| <Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-optimization</Uri> | |||
| <Sha>d0bb63d2ec7060714e63ee4082fac48f2e57f3e2</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.NET.Test.Sdk" Version="16.4.0"> | |||
There was a problem hiding this comment.
Are we going to consume this via maestro? Are they already publishing to BAR?
There was a problem hiding this comment.
Yes:
https://github.com/Microsoft/vstest (.NET Core Tooling Dev) ==> 'https://github.com/dotnet/runtime' ('master')
- Id: 290ec264-66d2-456a-879f-08d75d523bc9
- Update Frequency: EveryDay
- Enabled: True
- Batchable: True
- Merge Policies:
Standard
safern
reviewed
Nov 21, 2019
safern
reviewed
Nov 21, 2019
safern
approved these changes
Nov 21, 2019
ghost
locked as resolved and limited conversation to collaborators
MichalStrehovsky
pushed a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Fixes #178
Related dotnet/arcade#4414
The existing package Microsoft.DotNet.CoreFxTesting lived in Arcade
because of no infrastructure being available to compile local tasks in
the repository. As the runtime repository now offers that we can inline
the testing framework.
Also upgraded the ReportGenerator global tool version.
cc @stephentoub