Improve Crossgen2 map file emitter #35459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have rewritten the file name emitter with two main goals in mind: 1) Fix the long-standing problem that map file wasn't showing true RVA's of the individual symbols / nodes, making it harder to correlate its information with in-memory R2R PE layout. 2) Add section size and statistics section roughly mimicking what JanV presented in his recent analytic breakdown of R2R contents. Thanks Tomas
|
/cc @dotnet/crossgen-contrib |
trylek
commented
Apr 26, 2020
| } | ||
| } | ||
|
|
||
| foreach (MapFileNode node in _nodes) |
There was a problem hiding this comment.
Hehe, this is a dummy leftover from v#1 node list. Will delete :-).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rewritten the map file emitter with two main goals in mind:
Fix the long-standing problem that map file wasn't showing true
RVA's of the individual symbols / nodes, making it harder to
correlate its information with in-memory R2R PE layout.
Add section size and statistics section roughly mimicking what
JanV presented in his recent analytic breakdown of R2R contents.
Thanks
Tomas