Renamed SignatureProvider to DataFormatSigner so SignatureProvider can be used by the new SignatureProvider libraries. #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be used by the new SignatureProvider libraries.
dlemstra
force-pushed
the
rename-signature-provider-to-data-format-signer
branch
from
e299821 to
50d2d91
Compare
clairernovotny
approved these changes
Jun 12, 2024
|
@clairernovotny, I was still reviewing this when it merged. :( @dlemstra, can you please rename the folder https://github.com/dotnet/sign/tree/main/src/Sign.Core/SignatureProviders to DataFormatSigners? |
|
Eek, sorry! |
|
@dtivel Would you be okay with me renaming that folder in a PR where I move the |
Merged
|
I noticed that there were some issues when moving the NuGetSigner to a separate library. One of the is an incorrect ILogger injection. To address this and your comment I created a PR to fix this. For the other issue I will create a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name SignatureProvider is now use by the classes that are DataFormatSigners and we want this name to be used in the SignatureProvider libraries. Renaming all these classes and interfaces will make it possible to use this name.