Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Key Vault version support #789

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8a68bce
Add AKV Version support
Oct 31, 2024
ac33b0b
JC Add Tests for AKV versioning support
Nov 4, 2024
fad9d3b
JC Change certificate option abbreviation and variable for results na…
Nov 5, 2024
04a7e41
Update src/Sign.Cli/AzureKeyVaultResources.resx
jimmycartrette Nov 8, 2024
5874aa2
Update src/Sign.SignatureProviders.KeyVault/KeyVaultService.cs
jimmycartrette Nov 8, 2024
c190fc7
Update src/Sign.SignatureProviders.KeyVault/KeyVaultService.cs
jimmycartrette Nov 8, 2024
4f4dc5f
Update test/Sign.Cli.Test/AzureKeyVaultCommandTests.cs
jimmycartrette Nov 8, 2024
4deafa8
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
b8004ea
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
a95d35a
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
0ff170f
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTest…
jimmycartrette Nov 8, 2024
e74b831
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
8cbe250
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
6ba517d
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
ad577f2
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
b42ff97
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
9e81051
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
ae6fe5a
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
jimmycartrette Nov 8, 2024
145bf8a
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTest…
jimmycartrette Nov 8, 2024
cc40538
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTest…
jimmycartrette Nov 8, 2024
d8c6f6c
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTest…
jimmycartrette Nov 8, 2024
9f244ba
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTest…
jimmycartrette Nov 8, 2024
0489ae7
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTest…
jimmycartrette Nov 8, 2024
6480eaf
JC Run CIBuild for translations
Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProv…
…iderTests.cs

Co-authored-by: Damon Tivel <[email protected]>
  • Loading branch information
jimmycartrette and dtivel committed Nov 8, 2024
commit 6ba517d2f9be1ee87d6d76ab879fc08ea0429755
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void Constructor_WhenTokenCredentialIsNull_Throws()
public void Constructor_WhenKeyVaultUrlIsNull_Throws()
{
ArgumentNullException exception = Assert.Throws<ArgumentNullException>(
() => new KeyVaultServiceProvider(TokenCredential, keyVaultUrl: null!, CertificateName, null));
() => new KeyVaultServiceProvider(TokenCredential, keyVaultUrl: null!, CertificateName, certificateVersion: null));

Assert.Equal("keyVaultUrl", exception.ParamName);
}
Expand Down