Skip to content

Commit

Permalink
docs: Document --spawn_strategy=standalone for test
Browse files Browse the repository at this point in the history
Resolves bazelbuild#2571

Closes bazelbuild#3316.

PiperOrigin-RevId: 161930376
  • Loading branch information
harmank authored and laszlocsomor committed Jul 14, 2017
1 parent e045565 commit 0afe119
Show file tree
Hide file tree
Showing 5 changed files with 695 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ public static class BazelExecutionOptions extends OptionsBase {
documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
effectTags = {OptionEffectTag.UNKNOWN},
help =
"Specify how spawn actions are executed by default."
+ "'standalone' means run all of them locally."
+ "'sandboxed' means run them in namespaces based sandbox (available only on Linux)"
"Specify how spawn actions are executed by default. "
+ "'standalone' means run all of them locally without any kind of sandboxing. "
+ "'sandboxed' means to run them in a sandboxed environment with limited privileges "
+ "(details depend on platform support)."
)
public String spawnStrategy;

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
// Copyright 2016 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.devtools.build.android.ideinfo;

import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.fail;

import com.google.common.base.Joiner;
import com.google.devtools.build.lib.ideinfo.androidstudio.PackageManifestOuterClass.ArtifactLocation;
import com.google.devtools.common.options.OptionsParsingException;
import java.nio.file.Paths;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;

/**
* Tests {@link ArtifactLocationConverter}.
*/
@RunWith(JUnit4.class)
public class ArtifactLocationConverterTest {

private ArtifactLocationConverter converter;

@Before
public final void init() throws Exception {
converter = new ArtifactLocationConverter();
}

@Test
public void testConverterSourceArtifact() throws Exception {
ArtifactLocation parsed = converter.convert(
Joiner.on(',').join("", "test.java")
);
assertThat(parsed)
.isEqualTo(
ArtifactLocation.newBuilder()
.setRelativePath(Paths.get("test.java").toString())
.setIsSource(true)
.build());
}

@Test
public void testConverterDerivedArtifact() throws Exception {
ArtifactLocation parsed = converter.convert(
Joiner.on(',').join("bin", "java/com/test.java")
);
assertThat(parsed)
.isEqualTo(
ArtifactLocation.newBuilder()
.setRootExecutionPathFragment(Paths.get("bin").toString())
.setRelativePath(Paths.get("java/com/test.java").toString())
.setIsSource(false)
.build());
}

@Test
public void testConverterExternal() throws Exception {
ArtifactLocation externalArtifact =
converter.convert(Joiner.on(',').join("", "test.java", "1"));
assertThat(externalArtifact)
.isEqualTo(
ArtifactLocation.newBuilder()
.setRelativePath(Paths.get("test.java").toString())
.setIsSource(true)
.setIsExternal(true)
.build());
ArtifactLocation nonExternalArtifact =
converter.convert(Joiner.on(',').join("", "test.java", "0"));
assertThat(nonExternalArtifact)
.isEqualTo(
ArtifactLocation.newBuilder()
.setRelativePath(Paths.get("test.java").toString())
.setIsSource(true)
.setIsExternal(false)
.build());
}

@Test
public void testInvalidFormatFails() throws Exception {
assertFails("/root", ArtifactLocationConverter.INVALID_FORMAT);
assertFails("/root,exec,rel,extra", ArtifactLocationConverter.INVALID_FORMAT);
}

private void assertFails(String input, String expectedError) {
try {
new ArtifactLocationConverter().convert(input);
fail();
} catch (OptionsParsingException e) {
assertThat(e).hasMessage(expectedError);
}
}
}

52 changes: 52 additions & 0 deletions src/test/java/com/google/devtools/build/android/ideinfo/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
filegroup(
name = "srcs",
srcs = glob(["**"]),
visibility = ["//src/test/java/com/google/devtools/build/android:__pkg__"],
)

java_test(
name = "JarFilterTest",
size = "small",
srcs = ["JarFilterTest.java"],
deps = [
"//src/main/java/com/google/devtools/common/options",
"//src/main/protobuf:package_manifest_java_proto",
"//src/tools/android/java/com/google/devtools/build/android/ideinfo:jar_filter_lib",
"//third_party:guava",
"//third_party:jsr305",
"//third_party:junit4",
"//third_party:truth",
"//third_party/protobuf:protobuf_java",
],
)

java_test(
name = "PackageParserTest",
size = "small",
srcs = ["PackageParserTest.java"],
deps = [
"//src/main/java/com/google/devtools/common/options",
"//src/main/protobuf:package_manifest_java_proto",
"//src/tools/android/java/com/google/devtools/build/android/ideinfo:package_parser_lib",
"//third_party:guava",
"//third_party:jsr305",
"//third_party:junit4",
"//third_party:truth",
"//third_party/protobuf:protobuf_java",
],
)

java_test(
name = "ArtifactLocationConverterTest",
size = "small",
srcs = ["ArtifactLocationConverterTest.java"],
deps = [
"//src/main/java/com/google/devtools/common/options",
"//src/main/protobuf:package_manifest_java_proto",
"//src/tools/android/java/com/google/devtools/build/android/ideinfo:package_parser_lib",
"//third_party:guava",
"//third_party:junit4",
"//third_party:truth",
"//third_party/protobuf:protobuf_java",
],
)
Loading

0 comments on commit 0afe119

Please sign in to comment.