Skip to content

Commit

Permalink
Remove deprecated PE_IndicatorViewItemCheck and PE_FrameStatusBar
Browse files Browse the repository at this point in the history
They have been marked as deprecated since 5.13, and can be removed
from Qt 6 codebase, which silences the respective compiler warnings.

Change-Id: I3443c7bfa8db148b0b48957e2adc5eb131197faf
Reviewed-by: Timur Pocheptsov <[email protected]>
  • Loading branch information
vohi committed Oct 9, 2019
1 parent b5ff4c9 commit 0e12c8b
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/plugins/styles/android/qandroidstyle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ QAndroidStyle::ItemType QAndroidStyle::qtControl(QStyle::PrimitiveElement primit
case QStyle::PE_FrameLineEdit:
return QC_EditText;

case QStyle::PE_IndicatorViewItemCheck:
case QStyle::PE_IndicatorItemViewItemCheck:
case QStyle::PE_IndicatorCheckBox:
return QC_Checkbox;

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/styles/mac/qmacstyle_mac.mm
Original file line number Diff line number Diff line change
Expand Up @@ -3211,7 +3211,7 @@ const QPen arrowPen(opt->palette.text(), penWidth,

CGContextRestoreGState(cg);
break; }
case PE_IndicatorViewItemCheck:
case PE_IndicatorItemViewItemCheck:
case PE_IndicatorRadioButton:
case PE_IndicatorCheckBox: {
const bool isEnabled = opt->state & State_Enabled;
Expand Down
2 changes: 1 addition & 1 deletion src/widgets/doc/snippets/javastyle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2130,7 +2130,7 @@ void JavaStyle::drawPrimitive(PrimitiveElement element,
painter->restore();
break;
}
case PE_IndicatorViewItemCheck: {
case PE_IndicatorItemViewItemCheck: {
break;
}
case PE_FrameWindow: {
Expand Down
2 changes: 1 addition & 1 deletion src/widgets/doc/src/widgets-and-layouts/styles.qdoc
Original file line number Diff line number Diff line change
Expand Up @@ -1837,7 +1837,7 @@
item views keep the dimensions on individual sections. Also
note that the delegates may use the style to paint decorations
and frames around items. QItemDelegate, for instance, draws
\c PE_FrameFocusRect and \c PE_IndicatorViewItemCheck.
\c PE_FrameFocusRect and \c PE_IndicatorItemViewItemCheck.

\image javastyle/header.png

Expand Down
1 change: 0 additions & 1 deletion src/widgets/styles/qstyle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,6 @@ void QStyle::drawItemPixmap(QPainter *painter, const QRect &rect, int alignment,
indicator or button bevel.
\omitvalue PE_IndicatorViewItemCheck
\value PE_FrameStatusBar Obsolete. Use PE_FrameStatusBarItem instead.
\value PE_PanelButtonCommand Button used to initiate an action, for
example, a QPushButton.
Expand Down
6 changes: 0 additions & 6 deletions src/widgets/styles/qstyle.h
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ class Q_WIDGETS_EXPORT QStyle : public QObject
PE_FrameLineEdit,
PE_FrameMenu,
PE_FrameStatusBarItem,
#if QT_DEPRECATED_SINCE(5, 13) // ### Qt 6: remove
PE_FrameStatusBar Q_DECL_ENUMERATOR_DEPRECATED = PE_FrameStatusBarItem,
#endif
PE_FrameTabWidget,
PE_FrameWindow,
PE_FrameButtonBevel,
Expand All @@ -165,9 +162,6 @@ class Q_WIDGETS_EXPORT QStyle : public QObject
PE_IndicatorBranch,
PE_IndicatorButtonDropDown,
PE_IndicatorItemViewItemCheck,
#if QT_DEPRECATED_SINCE(5, 13) // ### Qt 6: remove
PE_IndicatorViewItemCheck Q_DECL_ENUMERATOR_DEPRECATED = PE_IndicatorItemViewItemCheck,
#endif
PE_IndicatorCheckBox,
PE_IndicatorDockWidgetResizeHandle,
PE_IndicatorHeaderArrow,
Expand Down

0 comments on commit 0e12c8b

Please sign in to comment.