Fix JSON parsing: make field type optional #212
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting the following error on
rbw sync
:rbw get: failed to sync database from server: failed to parse JSON: ciphers[21].fields[0]: missing field `Type` at line 1 column 45441
which is complaining about missing field
Type
.After the changes from PR, I was able to inspect the actual raw JSON from bitwarden server, and the offending json objects are due to the optional "type" field
The json are set via API call as opposed to via GUI, hence it's possible to not specify the field "type".
Just FYI, both the web interface and chrome extension works with the missing fields, where it will displays as follows:
I.e., it will just display nothing (neither text value nor as hidden). So
rbw
should also accept the schema as it's accepted by the server.