Skip to content

Commit

Permalink
QtConcurrent: fix warning about function parameters shadowing class m…
Browse files Browse the repository at this point in the history
…embers

No functional change.

Change-Id: I76aa01e8eb044c794d518ca72e6861cf95060dfc
Fixes: QTBUG-79071
Reviewed-by: Thiago Macieira <[email protected]>
  • Loading branch information
vohi committed Oct 8, 2019
1 parent 00e8f04 commit 0683de2
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions src/concurrent/qtconcurrentmapkernel.h
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,16 @@ class MappedReducedKernel : public IterateKernel<Iterator, ReducedResultType>
return false;
}

bool runIterations(Iterator sequenceBeginIterator, int begin, int end, ReducedResultType *) override
bool runIterations(Iterator sequenceBeginIterator, int beginIndex, int endIndex, ReducedResultType *) override
{
IntermediateResults<typename MapFunctor::result_type> results;
results.begin = begin;
results.end = end;
results.vector.reserve(end - begin);
results.begin = beginIndex;
results.end = endIndex;
results.vector.reserve(endIndex - beginIndex);

Iterator it = sequenceBeginIterator;
std::advance(it, begin);
for (int i = begin; i < end; ++i) {
std::advance(it, beginIndex);
for (int i = beginIndex; i < endIndex; ++i) {
results.vector.append(map(*(it)));
std::advance(it, 1);
}
Expand Down Expand Up @@ -176,13 +176,13 @@ class MappedEachKernel : public IterateKernel<Iterator, typename MapFunctor::res
return true;
}

bool runIterations(Iterator sequenceBeginIterator, int begin, int end, T *results) override
bool runIterations(Iterator sequenceBeginIterator, int beginIndex, int endIndex, T *results) override
{

Iterator it = sequenceBeginIterator;
std::advance(it, begin);
for (int i = begin; i < end; ++i) {
runIteration(it, i, results + (i - begin));
std::advance(it, beginIndex);
for (int i = beginIndex; i < endIndex; ++i) {
runIteration(it, i, results + (i - beginIndex));
std::advance(it, 1);
}

Expand Down

0 comments on commit 0683de2

Please sign in to comment.