Skip to content

Commit

Permalink
Doc: Fix coverity warnings in SQL snippets
Browse files Browse the repository at this point in the history
Fixes: QTBUG-83008
Change-Id: I126bc04719cd221a3d80ae825fca44e63aeec934
Reviewed-by: Topi Reiniö <[email protected]>
  • Loading branch information
paulwicking committed Mar 26, 2020
1 parent f22c929 commit 3f3e200
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
11 changes: 6 additions & 5 deletions src/sql/doc/snippets/code/doc_src_sql-driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ void testProc()
QSqlQuery q;
q.exec("call qtestproc (@outval1, @outval2)");
q.exec("select @outval1, @outval2");
q.next();
qDebug() << q.value(0) << q.value(1); // outputs "42" and "43"
if (q.next())
qDebug() << q.value(0) << q.value(1); // outputs "42" and "43"
//! [2]
}

Expand All @@ -87,7 +87,8 @@ db.setDatabaseName("C:\\test.gdb");
//! [25]
// connect to database using the Latin-1 character set
db.setConnectOptions("ISC_DPB_LC_CTYPE=Latin1");
db.open();
if (db.open())
qDebug("The database connection is open.");
//! [25]
}

Expand All @@ -96,8 +97,8 @@ void exProc()
//! [26]
QSqlQuery q;
q.exec("execute procedure my_procedure");
q.next();
qDebug() << q.value(0); // outputs the first RETURN/OUT value
if (q.next())
qDebug() << q.value(0); // outputs the first RETURN/OUT value
//! [26]

qDebug( \
Expand Down
7 changes: 4 additions & 3 deletions src/sql/doc/snippets/sqldatabase/sqldatabase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ void QSqlQuery_snippets()
QMap<QString, QVariant> sqlIterator(query.boundValues());
for (auto i = sqlIterator.begin(); i != sqlIterator.end(); ++i) {
cout << i.key().toUtf8().data() << ": "
<< i.value().toString().toUtf8().data() << Qt::endl;
<< i.value().toString().toUtf8().data() << "\n";
}
//! [14]
}
Expand All @@ -217,7 +217,7 @@ void QSqlQuery_snippets()
//! [15]
QList<QVariant> list = query.boundValues().values();
for (int i = 0; i < list.size(); ++i)
cout << i << ": " << list.at(i).toString().toUtf8().data() << Qt::endl;
cout << i << ": " << list.at(i).toString().toUtf8().data() << "\n";
//! [15]
}
}
Expand Down Expand Up @@ -274,6 +274,7 @@ void QSqlTableModel_snippets()
model.select();
int salary = model.record(4).value("salary").toInt();
//! [25]
Q_UNUSED(salary);
}
}

Expand Down Expand Up @@ -514,7 +515,7 @@ class XyzDriver : public QSqlDriver
const QString & /* password */, const QString & /* host */,
int /* port */, const QString & /* options */) override
{ return false; }
void close() {}
void close() override {}
QSqlResult *createResult() const override { return new XyzResult(this); }
};
//! [48]
Expand Down

0 comments on commit 3f3e200

Please sign in to comment.