ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

The cited commit fixed missing mirror packets by reset mirror when packets are modified but setting geneve options was also treated as a modified packet but should be treated as a part of set_tunnel which doesn't reset mirror. Fixes: feed7f6 ("ofproto-dpif-upcall: Mirror packets that are modified.") Acked-by: Simon Horman <[email protected]> Signed-off-by: Roi Dayan <[email protected]> Signed-off-by: Eelco Chaudron <[email protected]>
dqadri · Oct 13, 2023 · 834bd91 · 834bd91
1 parent d761930
commit 834bd91
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
@@ -7097,7 +7097,7 @@ reset_mirror_ctx(struct xlate_ctx *ctx, const struct flow *flow,
 
         set_field = ofpact_get_SET_FIELD(a);
         mf = set_field->field;
-        if (mf_are_prereqs_ok(mf, flow, NULL)) {
+        if (mf_are_prereqs_ok(mf, flow, NULL) && !mf_is_tun_metadata(mf)) {
             ctx->mirrors = 0;
         }
         return;