Skip to content

Commit

Permalink
ofproto-dpif: Trigger revalidation when ipfix config set.
Browse files Browse the repository at this point in the history
Currently, ipfix conf creation/deletion don't trigger dpif backer
revalidation. This is not expected, as we need the revalidation
to commit ipfix into xlate. So that xlate can generate ipfix
actions.

This patch covers only new creation/deletion of ipfix config.
Will upload one more patch to cover ipfix option changes.

Acked-by: Eelco Chaudron <[email protected]>
Signed-off-by: lic121 <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
  • Loading branch information
lic121 authored and igsilya committed Mar 4, 2022
1 parent 545b644 commit a9f5ee1
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ofproto/ofproto-dpif.c
Original file line number Diff line number Diff line change
Expand Up @@ -2371,6 +2371,12 @@ set_ipfix(
dpif_ipfix_unref(di);
ofproto->ipfix = NULL;
}

/* TODO: need to consider ipfix option changes more than
* enable/disable */
if (new_di || !ofproto->ipfix) {
ofproto->backer->need_revalidate = REV_RECONFIGURE;
}
}

return 0;
Expand Down

0 comments on commit a9f5ee1

Please sign in to comment.