[playframework#388] Fix Router.reverse(action).add(x,y)

dr3s · Dec 21, 2010 · df6faee · df6faee
1 parent e368f09
commit df6faee
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/framework/src/play/mvc/Router.java b/framework/src/play/mvc/Router.java
@@ -381,13 +381,12 @@ public static ActionDefinition reverse(String action, Map<String, Object> args)
         if (action.startsWith("controllers.")) {
             action = action.substring(12);
         }
-        Map<String, Object> argsbackup = args;
+        Map<String, Object> argsbackup = new HashMap<String, Object>(args);
         // Add routeArgs
         if (Scope.RouteArgs.current() != null) {
-            argsbackup.putAll(Scope.RouteArgs.current().data);
+            args.putAll(Scope.RouteArgs.current().data);
         }
         for (Route route : routes) {
-            args = new HashMap<String, Object>(argsbackup);
             if (route.actionPattern != null) {
                 Matcher matcher = route.actionPattern.matcher(action);
                 if (matcher.matches()) {
@@ -518,7 +517,7 @@ public static ActionDefinition reverse(String action, Map<String, Object> args)
                         actionDefinition.method = route.method == null || route.method.equals("*") ? "GET" : route.method.toUpperCase();
                         actionDefinition.star = "*".equals(route.method);
                         actionDefinition.action = action;
-                        actionDefinition.args = args;
+                        actionDefinition.args = argsbackup;
                         actionDefinition.host = host;
                         return actionDefinition;
                     }