Skip to content

Commit

Permalink
fix crashing bug in prev checkin
Browse files Browse the repository at this point in the history
  • Loading branch information
davehorton committed Dec 18, 2018
1 parent db5fb76 commit 5a32c26
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/sip-dialog-controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,8 @@ namespace drachtio {
nta_leg_client_reroute( leg, sip->sip_record_route, sip->sip_contact, false );

bool nat = false;
const sip_route_t* route;
if (nta_leg_get_route(leg, &route, NULL) >= 0 && isRfc1918(route->r_url->url_host)) {
const sip_route_t* route = NULL;
if (nta_leg_get_route(leg, &route, NULL) >= 0 && route && route->r_url && route->r_url->url_host && isRfc1918(route->r_url->url_host)) {
DR_LOG(log_info) << "SipDialogController::processResponse - (UAC) detected possible natted downstream client at RFC1918 address: " << route->r_url->url_host ;
nat = true;
}
Expand Down

5 comments on commit 5a32c26

@danieludy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, the code we are using does have the above fix in...

@davehorton
Copy link
Collaborator Author

@davehorton davehorton commented on 5a32c26 Dec 20, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieludy
Copy link

@danieludy danieludy commented on 5a32c26 Dec 20, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davehorton
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you just open the core file in gdb and enter 'bt' for a backtrace it should show you the trace where it crashed

@danieludy
Copy link

@danieludy danieludy commented on 5a32c26 Dec 20, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.