Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker build #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve docker build #294

wants to merge 1 commit into from
+57 −31

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jun 24, 2023

  • Use current code instead of cloning from github.
  • Use multi-stage instead of deleting everything.

@orgads orgads force-pushed the improve-docker branch 2 times, most recently from b103eea to 4083778 Compare June 29, 2023 12:54
@davehorton
Copy link
Collaborator

Hmm this fails for me.

Also, I don't like the fact that now we have lost the ability to see the specific git tag that this was built from.

g++ -DHAVE_CONFIG_H -I. -I.. <...> -DDRACHTIO_VERSION=\"1.0.0\"

@orgads
Copy link
Contributor Author

orgads commented Jun 29, 2023

The failure is:

Killed signal terminated program cc1plus

I don't see how that's related to any of my changes.

@orgads orgads force-pushed the improve-docker branch 2 times, most recently from 88393b1 to fc0ad4b Compare June 29, 2023 15:21
@orgads
Copy link
Contributor Author

orgads commented Jun 29, 2023

How about now? You can build with ./build-docker.sh, and it should use the current version.

@orgads
Copy link
Contributor Author

orgads commented Aug 21, 2023

Rebased. @davehorton ping.

@orgads
Improve docker build
ac584d8 
* Use current code instead of cloning from github.
* Use multi-stage instead of deleting everything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @davehorton