-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building with system hiredis #378
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was clearly not tested with a local hiredis install. In my testing if fails to build.
/usr/bin/ld: /home/runner/work/drachtio-server/drachtio-server/build/../src/blacklist.cpp:216: undefined reference to `redisFree'
/usr/bin/ld: src/drachtio-blacklist.o: in function `drachtio::QuerySentinel(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, boost::asio::ip::basic_endpoint<boost::asio::ip::tcp> const&, std::unordered_set<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)':
/home/runner/work/drachtio-server/drachtio-server/build/../src/blacklist.cpp:76: undefined reference to `redisConnect'
It was tested on docker. I'll test it further. |
55692dc
to
e635256
Compare
Sorry, I cherry-picked it from my branch with the wrong base. Should be ok now. |
e635256
to
3791912
Compare
@orgads |
Both work. The previous revision had |
No description provided.