Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local flag from bundle install #115

Open
wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
Open

Remove local flag from bundle install #115

wants to merge 1 commit into from

Conversation

raesene
Copy link
Contributor

@raesene raesene commented Jul 10, 2015

the bundle install command had the --local switch added, meaning that it would not connect to rubygems to try and install gems. As some of the gems are not in the vendor/cache it was failing, causing problems with the install.

So unless there's a specific reason to retain --local, this change suggests removing it.

the bundle install command had the --local switch added, meaning that it would not connect to rubygems to try and install gems.  As some of the gems are not in the vendor/cache it was failing, causing problems with the install.  

So unless there's a specific reason to retain --local, this change suggests removing it.
@etdsoft
Copy link
Member

etdsoft commented Jul 10, 2015

I think the right way around this problem is to make sure all dependencies are in vendor/cache/. The whole point of ./vendor/cache/ is to make sure the repo is self-contained at any given time.

I'll have a look and see what is the stuff we're missing to see if we can add it to the repo.

@raesene
Copy link
Contributor Author

raesene commented Jul 10, 2015

Fair enough, I think the challenge with that approach is some stuff (like the pdf and prawn stuff) gets pulled in by other gems so bundler misses it.

out of curiousity what's the reckoning on the benefit of the gems being in vendor/cache? Presumably most people installing Dradis are connected to the Internet, so will have access to rubygems, so the traffic volume would be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants