Skip to content

Commit

Permalink
Fixes ansible#6655 catch unicode encoding errors before sending to sy…
Browse files Browse the repository at this point in the history
…slog
  • Loading branch information
jctanner committed Mar 25, 2014
1 parent 7b8d1c0 commit 3194fbd
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions lib/ansible/module_utils/basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,12 @@ def _log_invocation(self):
else:
msg = 'Invoked'

# 6655 - allow for accented characters
try:
msg = unicode(msg).encode('utf8')
except UnicodeDecodeError, e:
pass

if (has_journal):
journal_args = ["MESSAGE=%s %s" % (module, msg)]
journal_args.append("MODULE=%s" % os.path.basename(__file__))
Expand All @@ -814,10 +820,10 @@ def _log_invocation(self):
except IOError, e:
# fall back to syslog since logging to journal failed
syslog.openlog(str(module), 0, syslog.LOG_USER)
syslog.syslog(syslog.LOG_NOTICE, unicode(msg).encode('utf8'))
syslog.syslog(syslog.LOG_NOTICE, msg) #1
else:
syslog.openlog(str(module), 0, syslog.LOG_USER)
syslog.syslog(syslog.LOG_NOTICE, unicode(msg).encode('utf8'))
syslog.syslog(syslog.LOG_NOTICE, msg) #2

def _set_cwd(self):
try:
Expand Down

0 comments on commit 3194fbd

Please sign in to comment.