Fixes ansible#6705 Give each role a unique uuid and apply tags only t…

…o tasks matching the uuid
dragon3 · Mar 26, 2014 · 8991e40 · 8991e40
1 parent c9f93cc
commit 8991e40
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/lib/ansible/playbook/play.py b/lib/ansible/playbook/play.py
@@ -26,6 +26,7 @@
 import shlex
 import os
 import sys
+import uuid
 
 class Play(object):
 
@@ -363,6 +364,13 @@ def _load_roles(self, roles, ds):
         new_tasks.append(dict(meta='flush_handlers'))
 
         roles = self._build_role_dependencies(roles, [], self.vars)
+
+        # give each role a uuid
+        for idx, val in enumerate(roles):
+            this_uuid = str(uuid.uuid4())
+            roles[idx][0]['role_uuid'] = this_uuid
+            roles[idx][-2]['role_uuid'] = this_uuid
+
         role_names = []
 
         for (role,role_path,role_vars,default_vars) in roles:
@@ -725,21 +733,21 @@ def _late_merge_role_tags(self):
         role_tags = {}
         for task in self._ds['tasks']:
             if 'role_name' in task:
-                this_role = task['role_name']
+                this_role = task['role_name'] + "-" + task['vars']['role_uuid']
 
                 if this_role not in role_tags:
                     role_tags[this_role] = []
 
                 if 'tags' in task['vars']:
                     if isinstance(task['vars']['tags'], basestring):
-                        role_tags[task['role_name']] += shlex.split(task['vars']['tags'])
+                        role_tags[this_role] += shlex.split(task['vars']['tags'])
                     else:
-                        role_tags[task['role_name']] += task['vars']['tags']
+                        role_tags[this_role] += task['vars']['tags']
 
         # apply each role's tags to it's tasks
         for idx, val in enumerate(self._tasks):
-            if hasattr(val, 'role_name'):
-                this_role = val.role_name
+            if getattr(val, 'role_name', None) is not None:
+                this_role = val.role_name + "-" + val.module_vars['role_uuid']
                 if this_role in role_tags:
                     self._tasks[idx].tags = sorted(set(self._tasks[idx].tags + role_tags[this_role]))