New icon for portfolio export and improving its position

The old icon was considered "temporary" (according to Penny) and it was not very clear. Hopefully this one is a bit better.
drakeg · Nov 12, 2010 · 628c784 · 628c784
1 parent d9e0726
commit 628c784
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 3 deletions.
diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
@@ -334,7 +334,7 @@ public function to_html($format=null, $addstr=null) {
 
         $formoutput = '<form method="post" action="' . $CFG->wwwroot . '/portfolio/add.php" id="portfolio-add-button">' . "\n";
         $formoutput .= html_writer::input_hidden_params($url);
-        $linkoutput = '<a title="'.$addstr.'" href="' . $url->out();
+        $linkoutput = '<a class="portfolio-add-link" title="'.$addstr.'" href="' . $url->out();
 
         switch ($format) {
             case PORTFOLIO_ADD_FULL_FORM:
@@ -344,11 +344,11 @@ public function to_html($format=null, $addstr=null) {
             break;
             case PORTFOLIO_ADD_ICON_FORM:
                 $formoutput .= $selectoutput;
-                $formoutput .= "\n" . '<input type="image" src="' . $OUTPUT->pix_url('t/portfolio') . '" alt=' . $addstr .'" />';
+                $formoutput .= "\n" . '<input class="portfolio-add-icon" type="image" src="' . $OUTPUT->pix_url('t/portfolioadd') . '" alt=' . $addstr .'" />';
                 $formoutput .= "\n" . '</form>';
             break;
             case PORTFOLIO_ADD_ICON_LINK:
-                $linkoutput .= '"><img src="' . $OUTPUT->pix_url('t/portfolio') . '" alt="' . $addstr .'" /></a>';
+                $linkoutput .= '"><img class="portfolio-add-icon" src="' . $OUTPUT->pix_url('t/portfolioadd') . '" alt="' . $addstr .'" /></a>';
             break;
             case PORTFOLIO_ADD_TEXT_LINK:
                 $linkoutput .= '">' . $addstr .'</a>';

diff --git a/pix/t/portfolio.gif b/pix/t/portfolio.gif
diff --git a/pix/t/portfolioadd.gif b/pix/t/portfolioadd.gif
diff --git a/pix/t/portfoliono.gif b/pix/t/portfoliono.gif
diff --git a/theme/standard/style/core.css b/theme/standard/style/core.css
@@ -442,3 +442,4 @@ table#tag-management-list {margin: 10px auto;width: 80%;}
 
 /* Portfolio */
 .path-portfolio .exportsummary {margin:0px auto 1em auto;}
+.portfolio-add-icon {margin-left:5px;}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -442,3 +442,4 @@ table#tag-management-list {margin: 10px auto;width: 80%;}

		/* Portfolio */
		.path-portfolio .exportsummary {margin:0px auto 1em auto;}
		.portfolio-add-icon {margin-left:5px;}