Fixed potential leak of temp pool.

In case ngx_hash_add_key() fails, need to goto failed instead of returning, so that temp_pool will be destoryed.
dreddy · Jun 15, 2020 · 1bbc37d · 1bbc37d
1 parent 0a683fd
commit 1bbc37d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/http/ngx_http.c b/src/http/ngx_http.c
@@ -1469,14 +1469,14 @@ ngx_http_server_names(ngx_conf_t *cf, ngx_http_core_main_conf_t *cmcf,
                                   NGX_HASH_WILDCARD_KEY);
 
             if (rc == NGX_ERROR) {
-                return NGX_ERROR;
+                goto failed;
             }
 
             if (rc == NGX_DECLINED) {
                 ngx_log_error(NGX_LOG_EMERG, cf->log, 0,
                               "invalid server name or wildcard \"%V\" on %V",
                               &name[n].name, &addr->opt.addr_text);
-                return NGX_ERROR;
+                goto failed;
             }
 
             if (rc == NGX_BUSY) {