Skip to content

Commit

Permalink
tpm: Separate TPM_TIS and TPM_TIS_ISA configs
Browse files Browse the repository at this point in the history
Let's separate the compilation of tpm_tis_common.c from
the compilation of tpm_tis_isa.c

The common part will be also compiled along with the
tpm_tis_sysbus device.

Signed-off-by: Eric Auger <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Tested-by: Ard Biesheuvel <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Berger <[email protected]>
  • Loading branch information
eauger authored and stefanberger committed Mar 5, 2020
1 parent ac90053 commit 2e8f767
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion default-configs/i386-softmmu.mak
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#CONFIG_SGA=n
#CONFIG_TEST_DEVICES=n
#CONFIG_TPM_CRB=n
#CONFIG_TPM_TIS=n
#CONFIG_TPM_TIS_ISA=n
#CONFIG_VTD=n

# Boards:
Expand Down
2 changes: 1 addition & 1 deletion hw/i386/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ config PC
imply SGA
imply TEST_DEVICES
imply TPM_CRB
imply TPM_TIS
imply TPM_TIS_ISA
imply VGA_PCI
imply VIRTIO_VGA
select FDC
Expand Down
7 changes: 6 additions & 1 deletion hw/tpm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,14 @@ config TPMDEV
bool
depends on TPM

config TPM_TIS
config TPM_TIS_ISA
bool
depends on TPM && ISA_BUS
select TPM_TIS

config TPM_TIS
bool
depends on TPM
select TPMDEV

config TPM_CRB
Expand Down
3 changes: 2 additions & 1 deletion hw/tpm/Makefile.objs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
common-obj-$(CONFIG_TPM) += tpm_util.o
obj-$(call lor,$(CONFIG_TPM_TIS),$(CONFIG_TPM_CRB)) += tpm_ppi.o
common-obj-$(CONFIG_TPM_TIS) += tpm_tis_isa.o tpm_tis_common.o
common-obj-$(CONFIG_TPM_TIS_ISA) += tpm_tis_isa.o
common-obj-$(CONFIG_TPM_TIS) += tpm_tis_common.o
common-obj-$(CONFIG_TPM_CRB) += tpm_crb.o
common-obj-$(CONFIG_TPM_PASSTHROUGH) += tpm_passthrough.o
common-obj-$(CONFIG_TPM_EMULATOR) += tpm_emulator.o
Expand Down
4 changes: 2 additions & 2 deletions tests/qtest/Makefile.include
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ check-qtest-i386-y += q35-test
check-qtest-i386-y += vmgenid-test
check-qtest-i386-$(CONFIG_TPM_CRB) += tpm-crb-swtpm-test
check-qtest-i386-$(CONFIG_TPM_CRB) += tpm-crb-test
check-qtest-i386-$(CONFIG_TPM_TIS) += tpm-tis-swtpm-test
check-qtest-i386-$(CONFIG_TPM_TIS) += tpm-tis-test
check-qtest-i386-$(CONFIG_TPM_TIS_ISA) += tpm-tis-swtpm-test
check-qtest-i386-$(CONFIG_TPM_TIS_ISA) += tpm-tis-test
check-qtest-i386-$(CONFIG_SLIRP) += test-netfilter
check-qtest-i386-$(CONFIG_POSIX) += test-filter-mirror
check-qtest-i386-$(CONFIG_RTL8139_PCI) += test-filter-redirector
Expand Down

0 comments on commit 2e8f767

Please sign in to comment.