Skip to content

Commit

Permalink
hw/char/xilinx_uartlite: Replace hw_error() by qemu_log_mask()
Browse files Browse the repository at this point in the history
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.

When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask().

Reviewed-by: Edgar E. Iglesias <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Alistair Francis <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
  • Loading branch information
philmd authored and pm215 committed May 21, 2020
1 parent 5a0001e commit 492edf3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions hw/char/xilinx_uartlite.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
*/

#include "qemu/osdep.h"
#include "hw/hw.h"
#include "qemu/log.h"
#include "hw/irq.h"
#include "hw/qdev-properties.h"
#include "hw/sysbus.h"
Expand Down Expand Up @@ -135,7 +135,8 @@ uart_write(void *opaque, hwaddr addr,
switch (addr)
{
case R_STATUS:
hw_error("write to UART STATUS?\n");
qemu_log_mask(LOG_GUEST_ERROR, "%s: write to UART STATUS\n",
__func__);
break;

case R_CTRL:
Expand Down

0 comments on commit 492edf3

Please sign in to comment.