Skip to content

Commit

Permalink
target/sh4: fix TCG leak during gusa sequence
Browse files Browse the repository at this point in the history
This fixes bug #1735384 while running java under qemu-sh4. When debug
was enabled it showed a problem with TCG temps. Once fixed I was able
to run java -version normally.

Cc: [email protected]
Reported-by: John Paul Adrian Glaubitz <[email protected]>
Suggested-by: Richard Henderson <[email protected]>
Signed-off-by: Alex Bennée <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Reviewed-by: Aurelien Jarno <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
  • Loading branch information
stsquad authored and aurel32 committed Dec 18, 2017
1 parent e691e0e commit 6d56fc6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target/sh4/translate.c
Original file line number Diff line number Diff line change
Expand Up @@ -2191,7 +2191,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State *env, int *pmax_insns)
}

/* If op_src is not a valid register, then op_arg was a constant. */
if (op_src < 0) {
if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) {
tcg_temp_free_i32(op_arg);
}

Expand Down

0 comments on commit 6d56fc6

Please sign in to comment.