net/slirp: fix leaks on forwarding rule registration error

Signed-off-by: Marc-André Lureau <[email protected]> Signed-off-by: Samuel Thibault <[email protected]>
dreddy · Feb 7, 2019 · 8e207c3 · 8e207c3
1 parent 8d45a3b
commit 8e207c3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/net/slirp.c b/net/slirp.c
@@ -807,6 +807,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str, Error **errp)
         qemu_chr_fe_init(&fwd->hd, chr, &err);
         if (err) {
             error_propagate(errp, err);
+            object_unparent(OBJECT(chr));
             g_free(fwd);
             return -1;
         }
@@ -815,6 +816,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str, Error **errp)
                                &server, port) < 0) {
             error_setg(errp, "Conflicting/invalid host:port in guest "
                        "forwarding rule '%s'", config_str);
+            qemu_chr_fe_deinit(&fwd->hd, true);
             g_free(fwd);
             return -1;
         }