Skip to content

Commit

Permalink
ui/console: Display the 'none' backend in '-display help'
Browse files Browse the repository at this point in the history
Commit c388f40 added the possibility to list the display
backends using '-display help'. Since the 'none' backend is
is not implemented as a DisplayChangeListenerOps, it is not
registered to the dpys[] array with qemu_display_register(),
and is not listed in the help output.

This might be confusing, as we list it in the man page:

  -display type
      Select type of display to use. This option is a replacement for
      the old style -sdl/-curses/... options. Valid values for type are

      none
          Do not display video output. The guest will still see an
          emulated graphics card, but its output will not be displayed
          to the QEMU user. This option differs from the -nographic
          option in that it only affects what is done with video
          output; -nographic also changes the destination of the serial
          and parallel port data.

Fix by manually listing the special 'none' backend in the help.

Suggested-by: Thomas Huth <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Message-id: [email protected]
Signed-off-by: Gerd Hoffmann <[email protected]>
  • Loading branch information
philmd authored and kraxel committed Jan 21, 2020
1 parent 557ba0e commit a1e8853
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ui/console.c
Original file line number Diff line number Diff line change
Expand Up @@ -2338,6 +2338,7 @@ void qemu_display_help(void)
int idx;

printf("Available display backend types:\n");
printf("none\n");
for (idx = DISPLAY_TYPE_NONE; idx < DISPLAY_TYPE__MAX; idx++) {
if (!dpys[idx]) {
ui_module_load_one(DisplayType_str(idx));
Expand Down

0 comments on commit a1e8853

Please sign in to comment.