cpus: join thread when removing a vCPU

If no one joins the thread, its associated memory is leaked. Reported-by: CheneyLin <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
dreddy · Feb 7, 2018 · dbadee4 · dbadee4
1 parent 8178e63
commit dbadee4
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/cpus.c b/cpus.c
@@ -1752,19 +1752,14 @@ void resume_all_vcpus(void)
     }
 }
 
-void cpu_remove(CPUState *cpu)
+void cpu_remove_sync(CPUState *cpu)
 {
     cpu->stop = true;
     cpu->unplug = true;
     qemu_cpu_kick(cpu);
-}
-
-void cpu_remove_sync(CPUState *cpu)
-{
-    cpu_remove(cpu);
-    while (cpu->created) {
-        qemu_cond_wait(&qemu_cpu_cond, &qemu_global_mutex);
-    }
+    qemu_mutex_unlock_iothread();
+    qemu_thread_join(cpu->thread);
+    qemu_mutex_lock_iothread();
 }
 
 /* For temporary buffers for forming a name */