Skip to content

Commit

Permalink
janitor: do not include qemu-char everywhere
Browse files Browse the repository at this point in the history
Touching char/char.h basically causes the whole of QEMU to
be rebuilt.  Avoid this, it is usually unnecessary.

Signed-off-by: Paolo Bonzini <[email protected]>
  • Loading branch information
bonzini committed Dec 19, 2012
1 parent 077805f commit f8fe796
Show file tree
Hide file tree
Showing 31 changed files with 7 additions and 25 deletions.
1 change: 0 additions & 1 deletion audio/alsaaudio.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include <alsa/asoundlib.h>
#include "qemu-common.h"
#include "main-loop.h"
#include "qemu-char.h"
#include "audio.h"

#if QEMU_GNUC_PREREQ(4, 3)
Expand Down
1 change: 0 additions & 1 deletion audio/ossaudio.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "qemu-common.h"
#include "main-loop.h"
#include "host-utils.h"
#include "qemu-char.h"
#include "audio.h"

#define AUDIO_CAP "oss"
Expand Down
1 change: 0 additions & 1 deletion block/raw-posix.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
*/
#include "qemu-common.h"
#include "qemu-timer.h"
#include "qemu-char.h"
#include "qemu-log.h"
#include "block_int.h"
#include "module.h"
Expand Down
1 change: 0 additions & 1 deletion bt-host.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/

#include "qemu-common.h"
#include "qemu-char.h"
#include "net.h"
#include "bt-host.h"
#include "main-loop.h"
Expand Down
1 change: 0 additions & 1 deletion bt-vhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/

#include "qemu-common.h"
#include "qemu-char.h"
#include "net.h"
#include "hw/bt.h"
#include "main-loop.h"
Expand Down
1 change: 0 additions & 1 deletion buffered_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "qemu-common.h"
#include "hw/hw.h"
#include "qemu-timer.h"
#include "qemu-char.h"
#include "buffered_file.h"

//#define DEBUG_BUFFERED_FILE
Expand Down
1 change: 1 addition & 0 deletions console.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "console.h"
#include "qemu-timer.h"
#include "qmp-commands.h"
#include "qemu-char.h"

//#define DEBUG_CONSOLE
#define DEFAULT_BACKSCROLL 512
Expand Down
1 change: 0 additions & 1 deletion console.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#ifndef CONSOLE_H
#define CONSOLE_H

#include "qemu-char.h"
#include "qemu-pixman.h"
#include "qdict.h"
#include "notify.h"
Expand Down
1 change: 1 addition & 0 deletions hmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

#include "hmp.h"
#include "net.h"
#include "qemu-char.h"
#include "qemu-option.h"
#include "qemu-timer.h"
#include "qmp-commands.h"
Expand Down
1 change: 0 additions & 1 deletion hw/9pfs/virtio-9p-coth.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
*
*/

#include "qemu-char.h"
#include "fsdev/qemu-fsdev.h"
#include "qemu-thread.h"
#include "qemu-coroutine.h"
Expand Down
1 change: 1 addition & 0 deletions hw/ivshmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "migration.h"
#include "qerror.h"
#include "event_notifier.h"
#include "qemu-char.h"

#include <sys/mman.h>
#include <sys/types.h>
Expand Down
2 changes: 0 additions & 2 deletions hw/spapr_hcall.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#include "sysemu.h"
#include "cpu.h"
#include "qemu-char.h"
#include "sysemu.h"
#include "qemu-char.h"
#include "helper_regs.h"
#include "hw/spapr.h"

Expand Down
1 change: 1 addition & 0 deletions hw/strongarm.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include "strongarm.h"
#include "qemu-error.h"
#include "arm-misc.h"
#include "qemu-char.h"
#include "sysemu.h"
#include "ssi.h"

Expand Down
1 change: 0 additions & 1 deletion hw/xen_disk.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include <sys/uio.h>

#include "hw.h"
#include "qemu-char.h"
#include "xen_backend.h"
#include "xen_blkif.h"
#include "blockdev.h"
Expand Down
1 change: 0 additions & 1 deletion hw/xen_nic.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
#include "net.h"
#include "net/checksum.h"
#include "net/util.h"
#include "qemu-char.h"
#include "xen_backend.h"

#include <xen/io/netif.h>
Expand Down
1 change: 0 additions & 1 deletion hw/xilinx_axidma.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
*/

#include "sysbus.h"
#include "qemu-char.h"
#include "qemu-timer.h"
#include "ptimer.h"
#include "qemu-log.h"
Expand Down
1 change: 0 additions & 1 deletion hw/xilinx_axienet.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
*/

#include "sysbus.h"
#include "qemu-char.h"
#include "qemu-log.h"
#include "net.h"
#include "net/checksum.h"
Expand Down
1 change: 1 addition & 0 deletions hw/xtensa_lx60.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include "sysbus.h"
#include "flash.h"
#include "blockdev.h"
#include "qemu-char.h"
#include "xtensa_bootparam.h"

typedef struct LxBoardDesc {
Expand Down
1 change: 0 additions & 1 deletion iohandler.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

#include "config-host.h"
#include "qemu-common.h"
#include "qemu-char.h"
#include "qemu-queue.h"
#include "qemu-aio.h"
#include "main-loop.h"
Expand Down
1 change: 0 additions & 1 deletion migration-exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "qemu-common.h"
#include "qemu_socket.h"
#include "migration.h"
#include "qemu-char.h"
#include "buffered_file.h"
#include "block.h"
#include <sys/types.h>
Expand Down
1 change: 0 additions & 1 deletion migration-fd.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "qemu_socket.h"
#include "migration.h"
#include "monitor.h"
#include "qemu-char.h"
#include "buffered_file.h"
#include "block.h"
#include "qemu_socket.h"
Expand Down
1 change: 0 additions & 1 deletion migration-tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "qemu-common.h"
#include "qemu_socket.h"
#include "migration.h"
#include "qemu-char.h"
#include "buffered_file.h"
#include "block.h"

Expand Down
1 change: 0 additions & 1 deletion migration-unix.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "qemu-common.h"
#include "qemu_socket.h"
#include "migration.h"
#include "qemu-char.h"
#include "buffered_file.h"
#include "block.h"

Expand Down
1 change: 0 additions & 1 deletion monitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define MONITOR_H

#include "qemu-common.h"
#include "qemu-char.h"
#include "qerror.h"
#include "qdict.h"
#include "block.h"
Expand Down
1 change: 1 addition & 0 deletions net/slirp.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "monitor.h"
#include "qemu_socket.h"
#include "slirp/libslirp.h"
#include "qemu-char.h"

static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
{
Expand Down
1 change: 0 additions & 1 deletion net/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include "net.h"
#include "clients.h"
#include "monitor.h"
#include "qemu-char.h"
#include "qemu-common.h"
#include "qemu-error.h"
#include "qemu-option.h"
Expand Down
1 change: 0 additions & 1 deletion net/tap.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include "clients.h"
#include "monitor.h"
#include "sysemu.h"
#include "qemu-char.h"
#include "qemu-common.h"
#include "qemu-error.h"

Expand Down
1 change: 0 additions & 1 deletion net/vde.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

#include "net.h"
#include "clients.h"
#include "qemu-char.h"
#include "qemu-common.h"
#include "qemu-option.h"

Expand Down
1 change: 1 addition & 0 deletions qmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "qemu-common.h"
#include "sysemu.h"
#include "qmp-commands.h"
#include "qemu-char.h"
#include "ui/qemu-spice.h"
#include "ui/vnc.h"
#include "kvm.h"
Expand Down
1 change: 0 additions & 1 deletion savevm.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
#include "monitor.h"
#include "sysemu.h"
#include "qemu-timer.h"
#include "qemu-char.h"
#include "audio/audio.h"
#include "migration.h"
#include "qemu_socket.h"
Expand Down
1 change: 0 additions & 1 deletion ui/qemu-spice.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

#include "qemu-option.h"
#include "qemu-config.h"
#include "qemu-char.h"
#include "monitor.h"

extern int using_spice;
Expand Down

0 comments on commit f8fe796

Please sign in to comment.