Issue 16 part2 #18
Merged
Issue 16 part2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-s-x
commented
Nov 3, 2017
| // ***************************** | ||
|
|
||
| function getStats(resource, parameters) { | ||
| return new Promise(function(resolve, reject) { |
There was a problem hiding this comment.
I didn't want to introduce another dependency so I simply wrapped existing request into new promise.
Promise required for async downloading of stats for all languages that the user solved the puzzle with.
There was a problem hiding this comment.
cgstats run in a nodejs 8+. Don't worry for Promise :p
d-s-x
commented
Nov 3, 2017
| @@ -126,37 +126,74 @@ app.get('/search*', function(req, res) { | |||
| }); | |||
| }); | |||
| } else if (optimizations.indexOf(game) != -1) { | |||
| getStats('LeaderboardsRemoteService/getFilteredPuzzleLeaderboard', | |||
| [game, , , {"active" : true, "column" : "keyword", "filter" : player}]) | |||
| .then(function (response) { | |||
There was a problem hiding this comment.
this response contains rankings only for requested keyword, like
{ users:
[ { pseudo: 'd-s-x',
rank: 63,
globalRank: 63,
localRank: 63,
score: 100,
testSessionHandle: '48277672d595cdc4b03e02abca6bda19f64a5cb',
programmingLanguage: 'Bash',
inProgress: false,
criteriaScore: 38,
company: '',
codingamer: [Object] },
{ pseudo: 'd-s-x',
rank: 64,
globalRank: 64,
localRank: 64,
score: 100,
testSessionHandle: '48277672d595cdc4b03e02abca6bda19f64a5cb',
programmingLanguage: 'Perl',
inProgress: false,
criteriaScore: 38,
company: '',
codingamer: [Object] },
{ pseudo: 'd-s-x',
rank: 221,
globalRank: 221,
localRank: 221,
score: 100,
testSessionHandle: '48277672d595cdc4b03e02abca6bda19f64a5cb',
programmingLanguage: 'Ruby',
inProgress: false,
criteriaScore: 50,
company: '',
codingamer: [Object] },
...
so we have to download more stats but with language filter instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores points calculation for optimization puzzles (code golf).
The issue is that in previous pull-request only rankings for current user were returned from cg server and as result the user always got 200 points.
This PR implements puzzle stats downloading for all languages that user solved the puzzle with.