Add size gap/lead for code golf #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-s-x
commented
Nov 6, 2017
| @@ -141,10 +141,7 @@ app.get('/search*', function(req, res) { | |||
| .then(function(responses) { | |||
| var users = responses.map(function(response) { | |||
| return response.users; | |||
| }) | |||
| .reduce(function(a, b) { | |||
| return a.concat(b); | |||
There was a problem hiding this comment.
no need to concat language stats into single array. Having the stats as array of array allows to use findIndex instead of foreach.
|
If you feel that the column title is not clear enough, you can add an html title with a clear explanation. I used it for the 95% confidence interval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 3 new columns to code golf puzzles: Code Size, Gap and Lead
Gap is difference between current and previous rank; lead is difference between current and next rank;
(not sure if captions are clear enough)
Gap N means that the player has to shave off N symbols to catch up with
rank-1player.Lead N means that
rank+1player has to shave off N symbols to catch up with the player.On the screenshot I'm 2nd in Javascript, both gap and lead are equal to 0. That means that 1st and 3rd ranks are at the same code size.