Skip to content

Commit

Permalink
[functions] Dont shade log4j2 in java runtime instance (apache#1881)
Browse files Browse the repository at this point in the history
*Motivation*

 apache#1849 shade the dependencies in java instance uber jar. However it
 shades the log4j2, which causes functions running in process mode
 can't output any logging messages.

*Solution*

Don't shade log4j2 in java runtime instance
  • Loading branch information
sijie authored and jerrypeng committed Jun 1, 2018
1 parent ec535b6 commit fc3c1b3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pulsar-functions/runtime-all/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,12 @@
<pattern>jersey</pattern>
<shadedPattern>org.apache.pulsar.functions.runtime.shaded.jersey</shadedPattern>
</relocation>
<!-- DONT ever shade log4j, otherwise logging won't work anymore in running functions in process mode
<relocation>
<pattern>org.apache.logging</pattern>
<shadedPattern>org.apache.pulsar.functions.runtime.shaded.org.apache.logging</shadedPattern>
</relocation>
-->
<relocation>
<pattern>javassist</pattern>
<shadedPattern>org.apache.pulsar.functions.runtime.shaded.javassist</shadedPattern>
Expand Down

0 comments on commit fc3c1b3

Please sign in to comment.