Custom expression editor: hide error on the correction attempt (metab…

…ase#19516)
driphub · Jan 4, 2022 · 4f078bc · 4f078bc
1 parent 0af13ab
commit 4f078bc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx b/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx
@@ -307,7 +307,7 @@ export default class ExpressionEditorTextfield extends React.Component {
   };
 
   handleExpressionChange(source) {
-    this.setState({ source });
+    this.setState({ source, errorMessage: null });
     if (this.props.onBlankChange) {
       this.props.onBlankChange(source.length === 0);
     }
@@ -400,7 +400,7 @@ export default class ExpressionEditorTextfield extends React.Component {
             highlightedIndex={this.state.highlightedSuggestionIndex}
           />
         </EditorContainer>
-        <ErrorMessage error={errorMessage} />
+        {!isFocused && <ErrorMessage error={errorMessage} />}
         <HelpText helpText={this.state.helpText} width={this.props.width} />
       </React.Fragment>
     );