Skip to content

Commit

Permalink
Excise 45 day clause from view line graph in audit (metabase#16906)
Browse files Browse the repository at this point in the history
  • Loading branch information
howonlee authored Jul 6, 2021
1 parent 37c50bb commit b65f466
Showing 1 changed file with 22 additions and 23 deletions.
45 changes: 22 additions & 23 deletions enterprise/backend/src/metabase_enterprise/audit/pages/queries.clj
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,12 @@
[:views {:display_name "Views", :base_type :type/Integer}]
[:avg_running_time {:display_name "Avg. Running Time (ms)", :base_type :type/Decimal}]]
:results (common/reducible-query
(-> {:select [[(hx/cast :date :started_at) :day]
[:%count.* :views]
[:%avg.running_time :avg_running_time]]
:from [:query_execution]
:group-by [(hx/cast :date :started_at)]
:order-by [[(hx/cast :date :started_at) :asc]]}
(common/add-45-days-clause :started_at)))})
{:select [[(hx/cast :date :started_at) :day]
[:%count.* :views]
[:%avg.running_time :avg_running_time]]
:from [:query_execution]
:group-by [(hx/cast :date :started_at)]
:order-by [[(hx/cast :date :started_at) :asc]]})})

(defn ^:internal-query-fn most-popular
"Query that returns the 10 most-popular Cards based on number of query executions, in descending order."
Expand All @@ -27,14 +26,14 @@
[:card_name {:display_name "Card", :base_type :type/Title, :remapped_from :card_id}]
[:executions {:display_name "Executions", :base_type :type/Integer}]]
:results (common/reducible-query
{:select [[:c.id :card_id]
[:c.name :card_name]
[:%count.* :executions]]
:from [[:query_execution :qe]]
:join [[:report_card :c] [:= :qe.card_id :c.id]]
:group-by [:c.id]
:order-by [[:executions :desc]]
:limit 10})})
{:select [[:c.id :card_id]
[:c.name :card_name]
[:%count.* :executions]]
:from [[:query_execution :qe]]
:join [[:report_card :c] [:= :qe.card_id :c.id]]
:group-by [:c.id]
:order-by [[:executions :desc]]
:limit 10})})

(defn ^:internal-query-fn ^:deprecated slowest
"Query that returns the 10 slowest-running Cards based on average query execution time, in descending order."
Expand All @@ -43,14 +42,14 @@
[:card_name {:display_name "Card", :base_type :type/Title, :remapped_from :card_id}]
[:avg_running_time {:display_name "Avg. Running Time (ms)", :base_type :type/Decimal}]]
:results (common/reducible-query
{:select [[:c.id :card_id]
[:c.name :card_name]
[:%avg.running_time :avg_running_time]]
:from [[:query_execution :qe]]
:join [[:report_card :c] [:= :qe.card_id :c.id]]
:group-by [:c.id]
:order-by [[:avg_running_time :desc]]
:limit 10})})
{:select [[:c.id :card_id]
[:c.name :card_name]
[:%avg.running_time :avg_running_time]]
:from [[:query_execution :qe]]
:join [[:report_card :c] [:= :qe.card_id :c.id]]
:group-by [:c.id]
:order-by [[:avg_running_time :desc]]
:limit 10})})

(s/defn ^:internal-query-fn table
"A list of all questions.
Expand Down

0 comments on commit b65f466

Please sign in to comment.