spapr_drc.c: do not error_report() when drc->dev->id == NULL

The error_report() call in drc_unisolate_logical() is not considering that drc->dev->id can be NULL, and the underlying functions error_report() calls to do its job (vprintf(), g_strdup_printf() ...) has undefined behavior when trying to handle "%s" with NULL arguments. Besides, there is no utility into reporting that an unknown device was rejected by the guest. Acked-by: David Gibson <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Daniel Henrique Barboza <[email protected]> Message-Id: <[email protected]> Signed-off-by: David Gibson <[email protected]>
driver1998 · Sep 29, 2021 · 91bd95c · 91bd95c
1 parent 44d886a
commit 91bd95c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
@@ -167,8 +167,11 @@ static uint32_t drc_unisolate_logical(SpaprDrc *drc)
             }
 
             drc->unplug_requested = false;
-            error_report("Device hotunplug rejected by the guest "
-                         "for device %s", drc->dev->id);
+
+            if (drc->dev->id) {
+                error_report("Device hotunplug rejected by the guest "
+                             "for device %s", drc->dev->id);
+            }
 
             /*
              * TODO: send a QAPI DEVICE_UNPLUG_ERROR event when