fix cypress test for vanilla-es6 (tastejs#1907)

drothmaler · Jul 1, 2018 · 302b409 · 302b409
1 parent 32ee33e
commit 302b409
Show file tree

Hide file tree

Showing 7 changed files with 72 additions and 15 deletions.
diff --git a/cypress/integration/spec.js b/cypress/integration/spec.js
@@ -89,7 +89,8 @@ const badLocalStorageFormat = {
 const blurAfterType = {
   ampersand: true,
   dijon: true,
-  duel: true
+  duel: true,
+  'vanilla-es6': true
 }
 
 // add after typing if `...{enter}` is not enough for some frameworks

diff --git a/examples/vanilla-es6/dist/bundle.js b/examples/vanilla-es6/dist/bundle.js
diff --git a/examples/vanilla-es6/node_modules/todomvc-app-css/index.css b/examples/vanilla-es6/node_modules/todomvc-app-css/index.css
diff --git a/examples/vanilla-es6/node_modules/todomvc-common/base.js b/examples/vanilla-es6/node_modules/todomvc-common/base.js
diff --git a/examples/vanilla-es6/package.json b/examples/vanilla-es6/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "scripts": {
-    "compile": "java -jar node_modules/google-closure-compiler/compiler.jar -O ADVANCED --language_in=ES6_STRICT --new_type_inf --js_output_file='dist/bundle.js' 'src/**.js' -W VERBOSE",
+    "compile": "java -jar node_modules/google-closure-compiler/compiler.jar --language_in=ES6_STRICT --new_type_inf --js_output_file='dist/bundle.js' 'src/**.js' -W VERBOSE",
     "prepublish": "npm run compile"
   },
   "dependencies": {

diff --git a/examples/vanilla-es6/src/template.js b/examples/vanilla-es6/src/template.js
@@ -19,9 +19,11 @@ export default class Template {
 	itemList(items) {
 		return items.reduce((a, item) => a + `
 <li data-id="${item.id}"${item.completed ? ' class="completed"' : ''}>
-	<input class="toggle" type="checkbox" ${item.completed ? 'checked' : ''}>
-	<label>${escapeForHTML(item.title)}</label>
-	<button class="destroy"></button>
+	<div class="view">
+		<input class="toggle" type="checkbox" ${item.completed ? 'checked' : ''}>
+		<label>${escapeForHTML(item.title)}</label>
+		<button class="destroy"></button>
+	</div>
 </li>`, '');
 	}
 

diff --git a/examples/vanilla-es6/src/view.js b/examples/vanilla-es6/src/view.js
@@ -2,7 +2,7 @@ import {ItemList} from './item';
 import {qs, $on, $delegate} from './helpers';
 import Template from './template';
 
-const _itemId = element => parseInt(element.parentNode.dataset.id, 10);
+const _itemId = element => parseInt(element.parentNode.dataset.id || element.parentNode.parentNode.dataset.id, 10);
 const ENTER_KEY = 13;
 const ESCAPE_KEY = 27;
 
@@ -30,7 +30,7 @@ export default class View {
 	 * @param {!Element} target Target Item's label Element
 	 */
 	editItem(target) {
-		const listItem = target.parentElement;
+		const listItem = target.parentElement.parentElement;
 
 		listItem.classList.add('editing');