Minimise errors when using includes & excludes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If includes is called on an input that supports the method then call it, otherwise return false. If we encounter a type error (e.g. String.include?(Integer) ) then also return false. Due to the enhanced complexity of the predicate lets make excludes? simply be its opposite.
| input.include?(value) | ||
| begin | ||
| case input | ||
| when String, Range, Array, Hash then input.include?(value) |
There was a problem hiding this comment.
I wonder if we could just check if respond_to?(:include?) instead of listing these types?
There was a problem hiding this comment.
That sounds nicer. Also makes it more flexible with custom classes.
I also really hate rescuing the type error but if couldn't think of a better way...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If includes is called on an input that supports the method then call
it, otherwise return false.
If we encounter a type error (e.g. String.include?(Integer) ) then also
return false.
Due to the enhanced complexity of the predicate lets make excludes?
simply be its opposite.
Fixes #10