Param names in ast v2 #17

fran-worley · 2016-06-08T00:10:59Z

This updates the AST to include predicate argument names and is a much cleaner solution than #13.

@solnic your thoughts please?

This changes the AST to include param names even when predicates are curried. Currently failing as we need to capture call args somehow to enable correct AST generation for results.

inject input into rule and predicate ast

(fixes failures in dry-validation with each & schema)

solnic · 2016-06-08T10:47:49Z

lib/dry/logic/rule.rb

+        curry_args = predicate.respond_to?(:arity) && predicate.arity != 0 ? args : []
+        if predicate.is_a?(Proc)
+          predicate.curry[*curry_args]
+        elsif predicate != nil


this looks suspicious, a rule with a nil predicate means there's a bug in our code, we shouldn't have a guard like that

fran-worley · 2016-06-08T13:02:41Z

We've got to add specs to the rule compiler & update it to work with the new ast
https://github.com/dry-rb/dry-logic/blob/master/lib/dry/logic/rule_compiler.rb#L54

solnic · 2016-06-09T11:20:06Z

We made it 🎉

fran-worley added 7 commits June 7, 2016 14:59

WIP 1

421119a

This changes the AST to include param names even when predicates are curried. Currently failing as we need to capture call args somehow to enable correct AST generation for results.

WIP 2

9a6d975

inject input into rule and predicate ast

Lets revert injection of input into rule ast.

dbdce12

Merge branch 'master' into param_names_in_ast_v2

d8620db

fix expectation to allow for reversed check rule args

9a16974

include input in predicate ast

a533844

Shouldn't try to curry predicates that don't exist

d298fc8

(fixes failures in dry-validation with each & schema)

solnic reviewed Jun 8, 2016
View reviewed changes

fran-worley and others added 3 commits June 8, 2016 11:59

remove nil check

d7a62b7

Minor formatting fix

46dba16

Add Rule::Composite#curry

31b8e45

solnic added 3 commits June 8, 2016 19:03

Update rule compiler to use extended predicate ast

1ffe94b

Add support for binding a predicate

5bd1aa3

Use Predicate::Undefined for undefined args

ea22a82

solnic mentioned this pull request Jun 9, 2016

Include argument names in AST #13

Closed

solnic merged commit 2f26dfd into master Jun 9, 2016

solnic deleted the param_names_in_ast_v2 branch June 9, 2016 11:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Param names in ast v2 #17

Param names in ast v2 #17

fran-worley commented Jun 8, 2016

solnic Jun 8, 2016

fran-worley commented Jun 8, 2016

solnic commented Jun 9, 2016

Param names in ast v2 #17

Param names in ast v2 #17

Conversation

fran-worley commented Jun 8, 2016

solnic Jun 8, 2016

Choose a reason for hiding this comment

fran-worley commented Jun 8, 2016

solnic commented Jun 9, 2016