Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call methods directly instead of using self[] #24

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

george-carlin
Copy link
Contributor

As mentioned on gitter ;)

Copy link
Contributor

@fran-worley fran-worley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be potentially confusing where a predicate has the same name as a standard ruby method?

@george-carlin
Copy link
Contributor Author

For reference, I opened this PR in response to @solnic's comment here:
https://gitter.im/dry-rb/chat?at=5812097983a2008d22dbe7e7

On 29 October 2016 at 15:24, Fran Worley [email protected] wrote:

@fran-worley commented on this pull request.

Could this be potentially confusing where a predicate has the same name as
a standard ruby method?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#24 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACiI5WKPDgdO5nRunC6VeiV55Ef6CI3nks5q41ccgaJpZM4KkHV3
.

@fran-worley
Copy link
Contributor

Thanks @headstock . Just found that as you sent it. In that case it's lovely, I doubt anyone who might get confused would be digging that deep into dry-logic anyway!

@solnic
Copy link
Member

solnic commented Oct 31, 2016

Sweet, thank you :)

@solnic solnic merged commit bed90e0 into dry-rb:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants