Add predicates for checking V1, V2, V3, V5 UUIDs. #75

jamesbrauman · 2020-08-13T03:56:32Z

I have a need to validate other versions of UUIDs than just V4. Because the uuid_v4? predicate exists, can we also add predicates for other UUID versions?

Should I also add a uuid? predicate that checks for V1-V5 UUIDs?

Reference: https://stackoverflow.com/a/38191104

dry-bot · 2020-08-13T03:58:17Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 44
           

Clones added
============
- spec/unit/predicates/uuid_v3_spec.rb  1
- spec/unit/predicates/uuid_v1_spec.rb  1
- spec/unit/predicates/uuid_v5_spec.rb  1
- spec/unit/predicates/uuid_v2_spec.rb  1

See the complete overview on Codacy

dry-bot · 2020-08-13T03:58:18Z

spec/unit/predicates/uuid_v1_spec.rb

+        [['f2d26c57-e07c-1416-a749-57e937930e04']]
+      end
+
+      it_behaves_like 'a passing predicate'


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:19Z

lib/dry/logic/predicates.rb

@@ -206,11 +206,31 @@ def case?(pattern, input)
          pattern === input
        end

+        def uuid_v1?(input)
+          uuid_v1_format = /\A[0-9A-F]{8}-[0-9A-F]{4}-1[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}\z/i


Codacy found an issue: Line is too long. [101/100]

dry-bot · 2020-08-13T03:58:20Z

spec/unit/predicates/uuid_v5_spec.rb

+
+    context 'when value is a valid V5 UUID' do
+      let(:arguments_list) do
+        [['f2d26c57-e07c-5416-a749-57e937930e04']]


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:20Z

spec/unit/predicates/uuid_v1_spec.rb

+      it_behaves_like 'a passing predicate'
+    end
+
+    context 'with value is not a valid V1 UUID' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:21Z

spec/unit/predicates/uuid_v3_spec.rb

+      it_behaves_like 'a passing predicate'
+    end
+
+    context 'with value is not a valid V4 UUID' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:23Z

spec/unit/predicates/uuid_v2_spec.rb

+  describe '#uuid_v2?' do
+    let(:predicate_name) { :uuid_v2? }
+
+    context 'when value is a valid V1 UUID' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:24Z

spec/unit/predicates/uuid_v3_spec.rb

+require 'dry/logic/predicates'
+
+RSpec.describe Dry::Logic::Predicates do
+  describe '#uuid_v3?' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:25Z

spec/unit/predicates/uuid_v1_spec.rb

+  describe '#uuid_v1?' do
+    let(:predicate_name) { :uuid_v1? }
+
+    context 'when value is a valid V1 UUID' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:26Z

spec/unit/predicates/uuid_v5_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'dry/logic/predicates'


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:27Z

spec/unit/predicates/uuid_v2_spec.rb

+        [
+          ["not-a-uuid-at-all\nf2d26c57-e07c-2416-a749-57e937930e04"], # V2 with invalid prefix
+          ["f2d26c57-e07c-2416-a749-57e937930e04\nnot-a-uuid-at-all"], # V2 with invalid suffix
+          ['f2d26c57-e07c-3416-a749-57e937930e04'], # wrong version number (3, not 2)


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:28Z

spec/unit/predicates/uuid_v2_spec.rb

+        [['f2d26c57-e07c-2416-a749-57e937930e04']]
+      end
+
+      it_behaves_like 'a passing predicate'


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:29Z

spec/unit/predicates/uuid_v2_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'dry/logic/predicates'


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:30Z

lib/dry/logic/predicates.rb

        def uuid_v4?(input)
          uuid_v4_format = /\A[0-9A-F]{8}-[0-9A-F]{4}-4[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}\z/i
          format?(uuid_v4_format, input)
        end

+        def uuid_v5?(input)
+          uuid_v5_format = /\A[0-9A-F]{8}-[0-9A-F]{4}-5[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}\z/i


Codacy found an issue: Line is too long. [101/100]

dry-bot · 2020-08-13T03:58:31Z

spec/unit/predicates/uuid_v5_spec.rb

+require 'dry/logic/predicates'
+
+RSpec.describe Dry::Logic::Predicates do
+  describe '#uuid_v5?' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:32Z

spec/unit/predicates/uuid_v3_spec.rb

+  describe '#uuid_v3?' do
+    let(:predicate_name) { :uuid_v3? }
+
+    context 'when value is a valid V3 UUID' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:33Z

spec/unit/predicates/uuid_v2_spec.rb

+require 'dry/logic/predicates'
+
+RSpec.describe Dry::Logic::Predicates do
+  describe '#uuid_v2?' do


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:33Z

spec/unit/predicates/uuid_v3_spec.rb

+        ]
+      end
+
+      it_behaves_like 'a failing predicate'


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:34Z

spec/unit/predicates/uuid_v5_spec.rb

+          ["f2d26c57-e07c-5416-a749-57e937930e04\nnot-a-uuid-at-all"], # V4 with invalid suffix
+          ['f2d26c57-e07c-3416-a749-57e937930e04'], # wrong version number (3, not 5)
+          ['20633928-6a07-11e9-a923-1681be663d3e'], # UUID V1
+          ['not-a-uuid-at-all']


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:35Z

spec/unit/predicates/uuid_v3_spec.rb

+
+    context 'when value is a valid V3 UUID' do
+      let(:arguments_list) do
+        [['f2d26c57-e07c-3416-a749-57e937930e04']]


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:36Z

spec/unit/predicates/uuid_v3_spec.rb

+          ["not-a-uuid-at-all\nf2d26c57-e07c-3416-a749-57e937930e04"], # V3 with invalid prefix
+          ["f2d26c57-e07c-3416-a749-57e937930e04\nnot-a-uuid-at-all"], # V3 with invalid suffix
+          ['f2d26c57-e07c-4416-a749-57e937930e04'], # wrong version number (4, not 3)
+          ['20633928-6a07-11e9-a923-1681be663d3e'], # UUID V1


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:37Z

spec/unit/predicates/uuid_v2_spec.rb

+          ["f2d26c57-e07c-2416-a749-57e937930e04\nnot-a-uuid-at-all"], # V2 with invalid suffix
+          ['f2d26c57-e07c-3416-a749-57e937930e04'], # wrong version number (3, not 2)
+          ['20633928-6a07-11e9-a923-1681be663d3e'], # UUID V1
+          ['not-a-uuid-at-all']


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:38Z

spec/unit/predicates/uuid_v3_spec.rb

+          ["f2d26c57-e07c-3416-a749-57e937930e04\nnot-a-uuid-at-all"], # V3 with invalid suffix
+          ['f2d26c57-e07c-4416-a749-57e937930e04'], # wrong version number (4, not 3)
+          ['20633928-6a07-11e9-a923-1681be663d3e'], # UUID V1
+          ['not-a-uuid-at-all']


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:39Z

spec/unit/predicates/uuid_v2_spec.rb

+          ["not-a-uuid-at-all\nf2d26c57-e07c-2416-a749-57e937930e04"], # V2 with invalid prefix
+          ["f2d26c57-e07c-2416-a749-57e937930e04\nnot-a-uuid-at-all"], # V2 with invalid suffix
+          ['f2d26c57-e07c-3416-a749-57e937930e04'], # wrong version number (3, not 2)
+          ['20633928-6a07-11e9-a923-1681be663d3e'], # UUID V1


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:40Z

spec/unit/predicates/uuid_v3_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'dry/logic/predicates'


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

dry-bot · 2020-08-13T03:58:41Z

spec/unit/predicates/uuid_v5_spec.rb

+        [
+          ["not-a-uuid-at-all\nf2d26c57-e07c-5416-a749-57e937930e04"], # V4 with invalid prefix
+          ["f2d26c57-e07c-5416-a749-57e937930e04\nnot-a-uuid-at-all"], # V4 with invalid suffix
+          ['f2d26c57-e07c-3416-a749-57e937930e04'], # wrong version number (3, not 5)


Codacy found an issue: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

solnic · 2020-08-13T10:35:21Z

@jamesbrauman thank you James, you can now enjoy your new predicates in the freshly released dry-logic 1.0.7 😄

jamesbrauman · 2020-08-13T23:42:56Z

@solnic Thank-you for responsiveness, and the dry-rb suite of gems!

Add predicates for checking V1, V2, V3, V5 UUIDs.

db63910

dry-bot reviewed Aug 13, 2020

View reviewed changes

solnic merged commit d9938d9 into dry-rb:master Aug 13, 2020

solnic added this to the 1.0.7 milestone Aug 13, 2020

jamesbrauman mentioned this pull request Aug 13, 2020

Fix incorrect comments in uuid_v1_spec and uuid_v5_spec files. #76

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add predicates for checking V1, V2, V3, V5 UUIDs. #75

Add predicates for checking V1, V2, V3, V5 UUIDs. #75

jamesbrauman commented Aug 13, 2020 •

edited

Loading

dry-bot commented Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

dry-bot Aug 13, 2020

solnic commented Aug 13, 2020

jamesbrauman commented Aug 13, 2020

		@@ -0,0 +1,31 @@
		# frozen_string_literal: true

		require 'dry/logic/predicates'

Add predicates for checking V1, V2, V3, V5 UUIDs. #75

Add predicates for checking V1, V2, V3, V5 UUIDs. #75

Conversation

jamesbrauman commented Aug 13, 2020 • edited Loading

dry-bot commented Aug 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

solnic commented Aug 13, 2020

jamesbrauman commented Aug 13, 2020

jamesbrauman commented Aug 13, 2020 •

edited

Loading